openzeppelin_relayer/domain/transaction/stellar/

utils.rs

//! Utility functions for Stellar transaction domain logic.
use crate::constants::{
    DEFAULT_CONVERSION_SLIPPAGE_PERCENTAGE, STELLAR_DEFAULT_TRANSACTION_FEE, STELLAR_MAX_OPERATIONS,
};
use crate::domain::relayer::xdr_utils::{extract_operations, xdr_needs_simulation};
use crate::models::{AssetSpec, OperationSpec, RelayerError, RelayerStellarPolicy};
use crate::services::provider::StellarProviderTrait;
use crate::services::stellar_dex::StellarDexServiceTrait;
use base64::{engine::general_purpose, Engine};
use chrono::{DateTime, Utc};
use serde::Serialize;
use soroban_rs::xdr::{
    AccountId, AlphaNum12, AlphaNum4, Asset, ChangeTrustAsset, ContractDataEntry, ContractId, Hash,
    LedgerEntryData, LedgerKey, LedgerKeyContractData, Limits, Operation, Preconditions,
    PublicKey as XdrPublicKey, ReadXdr, ScAddress, ScSymbol, ScVal, TimeBounds, TimePoint,
    TransactionEnvelope, TransactionMeta, Uint256, VecM,
};
use std::str::FromStr;
use stellar_strkey::ed25519::PublicKey;
use thiserror::Error;
use tracing::{debug, warn};

// ============================================================================
// Error Types
// ============================================================================

/// Errors that can occur during Stellar transaction utility operations.
///
/// This error type is specific to Stellar transaction utilities and provides
/// detailed error information. It can be converted to `RelayerError` using
/// the `From` trait implementation.
#[derive(Error, Debug, Serialize)]
pub enum StellarTransactionUtilsError {
    #[error("Sequence overflow: {0}")]
    SequenceOverflow(String),

    #[error("Failed to parse XDR: {0}")]
    XdrParseFailed(String),

    #[error("Failed to extract operations: {0}")]
    OperationExtractionFailed(String),

    #[error("Failed to check if simulation is needed: {0}")]
    SimulationCheckFailed(String),

    #[error("Failed to simulate transaction: {0}")]
    SimulationFailed(String),

    #[error("Transaction simulation returned no results")]
    SimulationNoResults,

    #[error("Failed to get DEX quote: {0}")]
    DexQuoteFailed(String),

    #[error("Invalid asset identifier format: {0}")]
    InvalidAssetFormat(String),

    #[error("Asset code too long (max {0} characters): {1}")]
    AssetCodeTooLong(usize, String),

    #[error("Too many operations (max {0})")]
    TooManyOperations(usize),

    #[error("Cannot add operations to fee-bump transactions")]
    CannotModifyFeeBump,

    #[error("Cannot set time bounds on fee-bump transactions")]
    CannotSetTimeBoundsOnFeeBump,

    #[error("V0 transactions are not supported")]
    V0TransactionsNotSupported,

    #[error("Cannot update sequence number on fee bump transaction")]
    CannotUpdateSequenceOnFeeBump,

    #[error("Invalid transaction format: {0}")]
    InvalidTransactionFormat(String),

    #[error("Invalid account address '{0}': {1}")]
    InvalidAccountAddress(String, String),

    #[error("Invalid contract address '{0}': {1}")]
    InvalidContractAddress(String, String),

    #[error("Failed to create {0} symbol: {1:?}")]
    SymbolCreationFailed(String, String),

    #[error("Failed to create {0} key vector: {1:?}")]
    KeyVectorCreationFailed(String, String),

    #[error("Failed to query contract data (Persistent) for {0}: {1}")]
    ContractDataQueryPersistentFailed(String, String),

    #[error("Failed to query contract data (Temporary) for {0}: {1}")]
    ContractDataQueryTemporaryFailed(String, String),

    #[error("Failed to parse ledger entry XDR for {0}: {1}")]
    LedgerEntryParseFailed(String, String),

    #[error("No entries found for {0}")]
    NoEntriesFound(String),

    #[error("Empty entries for {0}")]
    EmptyEntries(String),

    #[error("Unexpected ledger entry type for {0} (expected ContractData)")]
    UnexpectedLedgerEntryType(String),

    // Token-specific errors
    #[error("Asset code cannot be empty in asset identifier: {0}")]
    EmptyAssetCode(String),

    #[error("Issuer address cannot be empty in asset identifier: {0}")]
    EmptyIssuerAddress(String),

    #[error("Invalid issuer address length (expected {0} characters): {1}")]
    InvalidIssuerLength(usize, String),

    #[error("Invalid issuer address format (must start with '{0}'): {1}")]
    InvalidIssuerPrefix(char, String),

    #[error("Failed to fetch account for balance: {0}")]
    AccountFetchFailed(String),

    #[error("Failed to query trustline for asset {0}: {1}")]
    TrustlineQueryFailed(String, String),

    #[error("No trustline found for asset {0} on account {1}")]
    NoTrustlineFound(String, String),

    #[error("Unsupported trustline entry version")]
    UnsupportedTrustlineVersion,

    #[error("Unexpected ledger entry type for trustline query")]
    UnexpectedTrustlineEntryType,

    #[error("Balance too large (i128 hi={0}, lo={1}) to fit in u64")]
    BalanceTooLarge(i64, u64),

    #[error("Negative balance not allowed: i128 lo={0}")]
    NegativeBalanceI128(u64),

    #[error("Negative balance not allowed: i64={0}")]
    NegativeBalanceI64(i64),

    #[error("Unexpected balance value type in contract data: {0:?}. Expected I128, U64, or I64")]
    UnexpectedBalanceType(String),

    #[error("Unexpected ledger entry type for contract data query")]
    UnexpectedContractDataEntryType,

    #[error("Native asset should be handled before trustline query")]
    NativeAssetInTrustlineQuery,

    #[error("Failed to invoke contract function '{0}': {1}")]
    ContractInvocationFailed(String, String),
}

impl From<StellarTransactionUtilsError> for RelayerError {
    fn from(error: StellarTransactionUtilsError) -> Self {
        match &error {
            StellarTransactionUtilsError::SequenceOverflow(msg)
            | StellarTransactionUtilsError::SimulationCheckFailed(msg)
            | StellarTransactionUtilsError::SimulationFailed(msg)
            | StellarTransactionUtilsError::XdrParseFailed(msg)
            | StellarTransactionUtilsError::OperationExtractionFailed(msg)
            | StellarTransactionUtilsError::DexQuoteFailed(msg) => {
                RelayerError::Internal(msg.clone())
            }
            StellarTransactionUtilsError::SimulationNoResults => RelayerError::Internal(
                "Transaction simulation failed: no results returned".to_string(),
            ),
            StellarTransactionUtilsError::InvalidAssetFormat(msg)
            | StellarTransactionUtilsError::InvalidTransactionFormat(msg) => {
                RelayerError::ValidationError(msg.clone())
            }
            StellarTransactionUtilsError::AssetCodeTooLong(max_len, code) => {
                RelayerError::ValidationError(format!(
                    "Asset code too long (max {max_len} characters): {code}"
                ))
            }
            StellarTransactionUtilsError::TooManyOperations(max) => {
                RelayerError::ValidationError(format!("Too many operations (max {max})"))
            }
            StellarTransactionUtilsError::CannotModifyFeeBump => RelayerError::ValidationError(
                "Cannot add operations to fee-bump transactions".to_string(),
            ),
            StellarTransactionUtilsError::CannotSetTimeBoundsOnFeeBump => {
                RelayerError::ValidationError(
                    "Cannot set time bounds on fee-bump transactions".to_string(),
                )
            }
            StellarTransactionUtilsError::V0TransactionsNotSupported => {
                RelayerError::ValidationError("V0 transactions are not supported".to_string())
            }
            StellarTransactionUtilsError::CannotUpdateSequenceOnFeeBump => {
                RelayerError::ValidationError(
                    "Cannot update sequence number on fee bump transaction".to_string(),
                )
            }
            StellarTransactionUtilsError::InvalidAccountAddress(_, msg)
            | StellarTransactionUtilsError::InvalidContractAddress(_, msg)
            | StellarTransactionUtilsError::SymbolCreationFailed(_, msg)
            | StellarTransactionUtilsError::KeyVectorCreationFailed(_, msg)
            | StellarTransactionUtilsError::ContractDataQueryPersistentFailed(_, msg)
            | StellarTransactionUtilsError::ContractDataQueryTemporaryFailed(_, msg)
            | StellarTransactionUtilsError::LedgerEntryParseFailed(_, msg) => {
                RelayerError::Internal(msg.clone())
            }
            StellarTransactionUtilsError::NoEntriesFound(_)
            | StellarTransactionUtilsError::EmptyEntries(_)
            | StellarTransactionUtilsError::UnexpectedLedgerEntryType(_)
            | StellarTransactionUtilsError::EmptyAssetCode(_)
            | StellarTransactionUtilsError::EmptyIssuerAddress(_)
            | StellarTransactionUtilsError::NoTrustlineFound(_, _)
            | StellarTransactionUtilsError::UnsupportedTrustlineVersion
            | StellarTransactionUtilsError::UnexpectedTrustlineEntryType
            | StellarTransactionUtilsError::BalanceTooLarge(_, _)
            | StellarTransactionUtilsError::NegativeBalanceI128(_)
            | StellarTransactionUtilsError::NegativeBalanceI64(_)
            | StellarTransactionUtilsError::UnexpectedBalanceType(_)
            | StellarTransactionUtilsError::UnexpectedContractDataEntryType
            | StellarTransactionUtilsError::NativeAssetInTrustlineQuery => {
                RelayerError::ValidationError(error.to_string())
            }
            StellarTransactionUtilsError::InvalidIssuerLength(expected, actual) => {
                RelayerError::ValidationError(format!(
                    "Invalid issuer address length (expected {expected} characters): {actual}"
                ))
            }
            StellarTransactionUtilsError::InvalidIssuerPrefix(prefix, addr) => {
                RelayerError::ValidationError(format!(
                    "Invalid issuer address format (must start with '{prefix}'): {addr}"
                ))
            }
            StellarTransactionUtilsError::AccountFetchFailed(msg)
            | StellarTransactionUtilsError::TrustlineQueryFailed(_, msg)
            | StellarTransactionUtilsError::ContractInvocationFailed(_, msg) => {
                RelayerError::ProviderError(msg.clone())
            }
        }
    }
}

/// Returns true if any operation needs simulation (contract invocation, creation, or wasm upload).
pub fn needs_simulation(operations: &[OperationSpec]) -> bool {
    operations.iter().any(|op| {
        matches!(
            op,
            OperationSpec::InvokeContract { .. }
                | OperationSpec::CreateContract { .. }
                | OperationSpec::UploadWasm { .. }
        )
    })
}

pub fn next_sequence_u64(seq_num: i64) -> Result<u64, RelayerError> {
    let next_i64 = seq_num
        .checked_add(1)
        .ok_or_else(|| RelayerError::ProviderError("sequence overflow".into()))?;
    u64::try_from(next_i64)
        .map_err(|_| RelayerError::ProviderError("sequence overflows u64".into()))
}

pub fn i64_from_u64(value: u64) -> Result<i64, RelayerError> {
    i64::try_from(value).map_err(|_| RelayerError::ProviderError("u64→i64 overflow".into()))
}

/// Detects if an error is due to a bad sequence number.
/// Returns true if the error message contains indicators of sequence number mismatch.
pub fn is_bad_sequence_error(error_msg: &str) -> bool {
    let error_lower = error_msg.to_lowercase();
    error_lower.contains("txbadseq")
}

/// Fetches the current sequence number from the blockchain and calculates the next usable sequence.
/// This is a shared helper that can be used by both stellar_relayer and stellar_transaction.
///
/// # Returns
/// The next usable sequence number (on-chain sequence + 1)
pub async fn fetch_next_sequence_from_chain<P>(
    provider: &P,
    relayer_address: &str,
) -> Result<u64, String>
where
    P: StellarProviderTrait,
{
    debug!(
        "Fetching sequence from chain for address: {}",
        relayer_address
    );

    // Fetch account info from chain
    let account = provider.get_account(relayer_address).await.map_err(|e| {
        warn!(
            address = %relayer_address,
            error = %e,
            "get_account failed in fetch_next_sequence_from_chain"
        );
        format!("Failed to fetch account from chain: {e}")
    })?;

    let on_chain_seq = account.seq_num.0; // Extract the i64 value
    let next_usable = next_sequence_u64(on_chain_seq)
        .map_err(|e| format!("Failed to calculate next sequence: {e}"))?;

    debug!(
        "Fetched sequence from chain: on-chain={}, next usable={}",
        on_chain_seq, next_usable
    );
    Ok(next_usable)
}

/// Convert a V0 transaction to V1 format for signing.
/// This is needed because the signature payload for V0 transactions uses V1 format internally.
pub fn convert_v0_to_v1_transaction(
    v0_tx: &soroban_rs::xdr::TransactionV0,
) -> soroban_rs::xdr::Transaction {
    soroban_rs::xdr::Transaction {
        source_account: soroban_rs::xdr::MuxedAccount::Ed25519(
            v0_tx.source_account_ed25519.clone(),
        ),
        fee: v0_tx.fee,
        seq_num: v0_tx.seq_num.clone(),
        cond: match v0_tx.time_bounds.clone() {
            Some(tb) => soroban_rs::xdr::Preconditions::Time(tb),
            None => soroban_rs::xdr::Preconditions::None,
        },
        memo: v0_tx.memo.clone(),
        operations: v0_tx.operations.clone(),
        ext: soroban_rs::xdr::TransactionExt::V0,
    }
}

/// Create a signature payload for the given envelope type
pub fn create_signature_payload(
    envelope: &soroban_rs::xdr::TransactionEnvelope,
    network_id: &soroban_rs::xdr::Hash,
) -> Result<soroban_rs::xdr::TransactionSignaturePayload, RelayerError> {
    let tagged_transaction = match envelope {
        soroban_rs::xdr::TransactionEnvelope::TxV0(e) => {
            // For V0, convert to V1 transaction format for signing
            let v1_tx = convert_v0_to_v1_transaction(&e.tx);
            soroban_rs::xdr::TransactionSignaturePayloadTaggedTransaction::Tx(v1_tx)
        }
        soroban_rs::xdr::TransactionEnvelope::Tx(e) => {
            soroban_rs::xdr::TransactionSignaturePayloadTaggedTransaction::Tx(e.tx.clone())
        }
        soroban_rs::xdr::TransactionEnvelope::TxFeeBump(e) => {
            soroban_rs::xdr::TransactionSignaturePayloadTaggedTransaction::TxFeeBump(e.tx.clone())
        }
    };

    Ok(soroban_rs::xdr::TransactionSignaturePayload {
        network_id: network_id.clone(),
        tagged_transaction,
    })
}

/// Create signature payload for a transaction directly (for operations-based signing)
pub fn create_transaction_signature_payload(
    transaction: &soroban_rs::xdr::Transaction,
    network_id: &soroban_rs::xdr::Hash,
) -> soroban_rs::xdr::TransactionSignaturePayload {
    soroban_rs::xdr::TransactionSignaturePayload {
        network_id: network_id.clone(),
        tagged_transaction: soroban_rs::xdr::TransactionSignaturePayloadTaggedTransaction::Tx(
            transaction.clone(),
        ),
    }
}

/// Update the sequence number in a transaction envelope.
///
/// Only V1 (Tx) envelopes are supported; V0 and fee-bump envelopes return an error.
pub fn update_envelope_sequence(
    envelope: &mut TransactionEnvelope,
    sequence: i64,
) -> Result<(), StellarTransactionUtilsError> {
    match envelope {
        TransactionEnvelope::Tx(v1) => {
            v1.tx.seq_num = soroban_rs::xdr::SequenceNumber(sequence);
            Ok(())
        }
        TransactionEnvelope::TxV0(_) => {
            Err(StellarTransactionUtilsError::V0TransactionsNotSupported)
        }
        TransactionEnvelope::TxFeeBump(_) => {
            Err(StellarTransactionUtilsError::CannotUpdateSequenceOnFeeBump)
        }
    }
}

/// Extract the fee (in stroops) from a V1 transaction envelope.
pub fn envelope_fee_in_stroops(
    envelope: &TransactionEnvelope,
) -> Result<u64, StellarTransactionUtilsError> {
    match envelope {
        TransactionEnvelope::Tx(env) => Ok(u64::from(env.tx.fee)),
        _ => Err(StellarTransactionUtilsError::InvalidTransactionFormat(
            "Expected V1 transaction envelope".to_string(),
        )),
    }
}

// ============================================================================
// Account and Contract Address Utilities
// ============================================================================

/// Parse a Stellar account address string into an AccountId XDR type.
///
/// # Arguments
///
/// * `account_id` - Stellar account address (must be valid PublicKey)
///
/// # Returns
///
/// AccountId XDR type or error if address is invalid
pub fn parse_account_id(account_id: &str) -> Result<AccountId, StellarTransactionUtilsError> {
    let account_pk = PublicKey::from_str(account_id).map_err(|e| {
        StellarTransactionUtilsError::InvalidAccountAddress(account_id.to_string(), e.to_string())
    })?;
    let account_uint256 = Uint256(account_pk.0);
    let account_xdr_pk = XdrPublicKey::PublicKeyTypeEd25519(account_uint256);
    Ok(AccountId(account_xdr_pk))
}

/// Parse a contract address string into a ContractId and extract the hash.
///
/// # Arguments
///
/// * `contract_address` - Contract address in StrKey format
///
/// # Returns
///
/// Contract hash (Hash) or error if address is invalid
pub fn parse_contract_address(
    contract_address: &str,
) -> Result<Hash, StellarTransactionUtilsError> {
    let contract_id = ContractId::from_str(contract_address).map_err(|e| {
        StellarTransactionUtilsError::InvalidContractAddress(
            contract_address.to_string(),
            e.to_string(),
        )
    })?;
    Ok(contract_id.0)
}

// ============================================================================
// Contract Data Utilities
// ============================================================================

/// Create an ScVal key for contract data queries.
///
/// Creates a ScVal::Vec containing a symbol and optional address.
/// Used for SEP-41 token interface keys like "Balance" and "Decimals".
///
/// # Arguments
///
/// * `symbol` - Symbol name (e.g., "Balance", "Decimals")
/// * `address` - Optional ScAddress to include in the key
///
/// # Returns
///
/// ScVal::Vec key or error if creation fails
pub fn create_contract_data_key(
    symbol: &str,
    address: Option<ScAddress>,
) -> Result<ScVal, StellarTransactionUtilsError> {
    if address.is_none() {
        let sym = ScSymbol::try_from(symbol).map_err(|e| {
            StellarTransactionUtilsError::SymbolCreationFailed(symbol.to_string(), format!("{e:?}"))
        })?;
        return Ok(ScVal::Symbol(sym));
    }

    let mut key_items: Vec<ScVal> =
        vec![ScVal::Symbol(ScSymbol::try_from(symbol).map_err(|e| {
            StellarTransactionUtilsError::SymbolCreationFailed(symbol.to_string(), format!("{e:?}"))
        })?)];

    if let Some(addr) = address {
        key_items.push(ScVal::Address(addr));
    }

    let key_vec: VecM<ScVal, { u32::MAX }> = VecM::try_from(key_items).map_err(|e| {
        StellarTransactionUtilsError::KeyVectorCreationFailed(symbol.to_string(), format!("{e:?}"))
    })?;

    Ok(ScVal::Vec(Some(soroban_rs::xdr::ScVec(key_vec))))
}

/// Query contract data with Persistent/Temporary durability fallback.
///
/// Queries contract data storage, trying Persistent durability first,
/// then falling back to Temporary if not found. This handles both
/// production tokens (Persistent) and test tokens (Temporary).
///
/// # Arguments
///
/// * `provider` - Stellar provider for querying ledger entries
/// * `contract_hash` - Contract hash (Hash)
/// * `key` - ScVal key to query
/// * `error_context` - Context string for error messages
///
/// # Returns
///
/// GetLedgerEntriesResponse or error if query fails
pub async fn query_contract_data_with_fallback<P>(
    provider: &P,
    contract_hash: Hash,
    key: ScVal,
    error_context: &str,
) -> Result<soroban_rs::stellar_rpc_client::GetLedgerEntriesResponse, StellarTransactionUtilsError>
where
    P: StellarProviderTrait + Send + Sync,
{
    let contract_address_sc =
        soroban_rs::xdr::ScAddress::Contract(soroban_rs::xdr::ContractId(contract_hash));

    let mut ledger_key = LedgerKey::ContractData(LedgerKeyContractData {
        contract: contract_address_sc.clone(),
        key: key.clone(),
        durability: soroban_rs::xdr::ContractDataDurability::Persistent,
    });

    // Query ledger entry with Persistent durability
    let mut ledger_entries = provider
        .get_ledger_entries(&[ledger_key.clone()])
        .await
        .map_err(|e| {
            StellarTransactionUtilsError::ContractDataQueryPersistentFailed(
                error_context.to_string(),
                e.to_string(),
            )
        })?;

    // If not found, try Temporary durability
    if ledger_entries
        .entries
        .as_ref()
        .map(|e| e.is_empty())
        .unwrap_or(true)
    {
        ledger_key = LedgerKey::ContractData(LedgerKeyContractData {
            contract: contract_address_sc,
            key,
            durability: soroban_rs::xdr::ContractDataDurability::Temporary,
        });
        ledger_entries = provider
            .get_ledger_entries(&[ledger_key])
            .await
            .map_err(|e| {
                StellarTransactionUtilsError::ContractDataQueryTemporaryFailed(
                    error_context.to_string(),
                    e.to_string(),
                )
            })?;
    }

    Ok(ledger_entries)
}

/// Parse a ledger entry from base64 XDR string.
///
/// Handles both LedgerEntry and LedgerEntryChange formats. If the XDR is a
/// LedgerEntryChange, extracts the LedgerEntry from it.
///
/// # Arguments
///
/// * `xdr_string` - Base64-encoded XDR string
/// * `context` - Context string for error messages
///
/// # Returns
///
/// Parsed LedgerEntry or error if parsing fails
pub fn parse_ledger_entry_from_xdr(
    xdr_string: &str,
    context: &str,
) -> Result<LedgerEntryData, StellarTransactionUtilsError> {
    let trimmed_xdr = xdr_string.trim();

    // Ensure valid base64
    if general_purpose::STANDARD.decode(trimmed_xdr).is_err() {
        return Err(StellarTransactionUtilsError::LedgerEntryParseFailed(
            context.to_string(),
            "Invalid base64".to_string(),
        ));
    }

    // Parse as LedgerEntryData (what Soroban RPC actually returns)
    match LedgerEntryData::from_xdr_base64(trimmed_xdr, Limits::none()) {
        Ok(data) => Ok(data),
        Err(e) => Err(StellarTransactionUtilsError::LedgerEntryParseFailed(
            context.to_string(),
            format!("Failed to parse LedgerEntryData: {e}"),
        )),
    }
}

/// Extract ScVal from contract data entry.
///
/// Parses the first entry from GetLedgerEntriesResponse and extracts
/// the ScVal from ContractDataEntry.
///
/// # Arguments
///
/// * `ledger_entries` - Response from get_ledger_entries
/// * `context` - Context string for error messages and logging
///
/// # Returns
///
/// ScVal from contract data or error if extraction fails
pub fn extract_scval_from_contract_data(
    ledger_entries: &soroban_rs::stellar_rpc_client::GetLedgerEntriesResponse,
    context: &str,
) -> Result<ScVal, StellarTransactionUtilsError> {
    let entries = ledger_entries
        .entries
        .as_ref()
        .ok_or_else(|| StellarTransactionUtilsError::NoEntriesFound(context.into()))?;

    if entries.is_empty() {
        return Err(StellarTransactionUtilsError::EmptyEntries(context.into()));
    }

    let entry_xdr = &entries[0].xdr;
    let entry = parse_ledger_entry_from_xdr(entry_xdr, context)?;

    match entry {
        LedgerEntryData::ContractData(ContractDataEntry { val, .. }) => Ok(val.clone()),

        _ => Err(StellarTransactionUtilsError::UnexpectedLedgerEntryType(
            context.into(),
        )),
    }
}

/// Extracts the return value from TransactionMeta if available.
///
/// Supports both V3 and V4 TransactionMeta versions for backward compatibility.
/// - V3: soroban_meta.return_value (ScVal, required)
/// - V4: soroban_meta.return_value (Option<ScVal>, optional)
///
/// # Arguments
///
/// * `result_meta` - TransactionMeta to extract return value from
///
/// # Returns
///
/// Some(&ScVal) if return value is available, None otherwise
pub fn extract_return_value_from_meta(result_meta: &TransactionMeta) -> Option<&ScVal> {
    match result_meta {
        TransactionMeta::V3(meta_v3) => meta_v3.soroban_meta.as_ref().map(|m| &m.return_value),
        TransactionMeta::V4(meta_v4) => meta_v4
            .soroban_meta
            .as_ref()
            .and_then(|m| m.return_value.as_ref()),
        _ => None,
    }
}

/// Extract a u32 value from an ScVal.
///
/// Handles multiple ScVal types that can represent numeric values.
///
/// # Arguments
///
/// * `val` - ScVal to extract from
/// * `context` - Context string (for logging)
///
/// # Returns
///
/// Some(u32) if extraction succeeds, None otherwise
pub fn extract_u32_from_scval(val: &ScVal, context: &str) -> Option<u32> {
    let result = match val {
        ScVal::U32(n) => Ok(*n),
        ScVal::I32(n) => (*n).try_into().map_err(|_| "Negative I32"),
        ScVal::U64(n) => (*n).try_into().map_err(|_| "U64 overflow"),
        ScVal::I64(n) => (*n).try_into().map_err(|_| "I64 overflow/negative"),
        ScVal::U128(n) => {
            if n.hi == 0 {
                n.lo.try_into().map_err(|_| "U128 lo overflow")
            } else {
                Err("U128 hi set")
            }
        }
        ScVal::I128(n) => {
            if n.hi == 0 {
                n.lo.try_into().map_err(|_| "I128 lo overflow")
            } else {
                Err("I128 hi set/negative")
            }
        }
        _ => Err("Unsupported ScVal type"),
    };

    match result {
        Ok(v) => Some(v),
        Err(msg) => {
            warn!(context = %context, val = ?val, "Failed to extract u32: {}", msg);
            None
        }
    }
}

// ============================================================================
// Gas Abstraction Utility Functions
// ============================================================================

/// Convert raw token amount to UI amount based on decimals
///
/// Uses pure integer arithmetic to avoid floating-point precision errors.
/// This is safer for financial calculations where precision is critical.
pub fn amount_to_ui_amount(amount: u64, decimals: u8) -> String {
    if decimals == 0 {
        return amount.to_string();
    }

    let amount_str = amount.to_string();
    let len = amount_str.len();
    let decimals_usize = decimals as usize;

    let combined = if len > decimals_usize {
        let split_idx = len - decimals_usize;
        let whole = &amount_str[..split_idx];
        let frac = &amount_str[split_idx..];
        format!("{whole}.{frac}")
    } else {
        // Need to pad with leading zeros
        let zeros = "0".repeat(decimals_usize - len);
        format!("0.{zeros}{amount_str}")
    };

    // Trim trailing zeros
    let mut trimmed = combined.trim_end_matches('0').to_string();
    if trimmed.ends_with('.') {
        trimmed.pop();
    }

    // If we stripped everything (e.g. amount 0), return "0"
    if trimmed.is_empty() {
        "0".to_string()
    } else {
        trimmed
    }
}

/// Count operations in a transaction envelope from XDR base64 string
///
/// Parses the XDR string, extracts operations, and returns the count.
pub fn count_operations_from_xdr(xdr: &str) -> Result<usize, StellarTransactionUtilsError> {
    let envelope = TransactionEnvelope::from_xdr_base64(xdr, Limits::none()).map_err(|e| {
        StellarTransactionUtilsError::XdrParseFailed(format!("Failed to parse XDR: {e}"))
    })?;

    let operations = extract_operations(&envelope).map_err(|e| {
        StellarTransactionUtilsError::OperationExtractionFailed(format!(
            "Failed to extract operations: {e}"
        ))
    })?;

    Ok(operations.len())
}

/// Parse transaction and count operations
///
/// Supports both XDR (base64 string) and operations array formats
pub fn parse_transaction_and_count_operations(
    transaction_json: &serde_json::Value,
) -> Result<usize, StellarTransactionUtilsError> {
    // Try to parse as XDR string first
    if let Some(xdr_str) = transaction_json.as_str() {
        let envelope =
            TransactionEnvelope::from_xdr_base64(xdr_str, Limits::none()).map_err(|e| {
                StellarTransactionUtilsError::XdrParseFailed(format!("Failed to parse XDR: {e}"))
            })?;

        let operations = extract_operations(&envelope).map_err(|e| {
            StellarTransactionUtilsError::OperationExtractionFailed(format!(
                "Failed to extract operations: {e}"
            ))
        })?;

        return Ok(operations.len());
    }

    // Try to parse as operations array
    if let Some(ops_array) = transaction_json.as_array() {
        return Ok(ops_array.len());
    }

    // Try to parse as object with operations field
    if let Some(obj) = transaction_json.as_object() {
        if let Some(ops) = obj.get("operations") {
            if let Some(ops_array) = ops.as_array() {
                return Ok(ops_array.len());
            }
        }
        if let Some(xdr_str) = obj.get("transaction_xdr").and_then(|v| v.as_str()) {
            let envelope =
                TransactionEnvelope::from_xdr_base64(xdr_str, Limits::none()).map_err(|e| {
                    StellarTransactionUtilsError::XdrParseFailed(format!(
                        "Failed to parse XDR: {e}"
                    ))
                })?;

            let operations = extract_operations(&envelope).map_err(|e| {
                StellarTransactionUtilsError::OperationExtractionFailed(format!(
                    "Failed to extract operations: {e}"
                ))
            })?;

            return Ok(operations.len());
        }
    }

    Err(StellarTransactionUtilsError::InvalidTransactionFormat(
        "Transaction must be either XDR string or operations array".to_string(),
    ))
}

/// Fee quote structure containing fee estimates in both tokens and stroops
#[derive(Debug)]
pub struct FeeQuote {
    pub fee_in_token: u64,
    pub fee_in_token_ui: String,
    pub fee_in_stroops: u64,
    pub conversion_rate: f64,
}

/// Estimate the base transaction fee in XLM (stroops)
///
/// For Stellar, the base fee is typically 100 stroops per operation.
pub fn estimate_base_fee(num_operations: usize) -> u64 {
    (num_operations.max(1) as u64) * STELLAR_DEFAULT_TRANSACTION_FEE as u64
}

/// Estimate transaction fee in XLM (stroops) based on envelope content
///
/// This function intelligently estimates fees by:
/// 1. Checking if the transaction needs simulation (contains Soroban operations)
/// 2. If simulation is needed, performs simulation and uses `min_resource_fee` from the response
/// 3. If simulation is not needed, counts operations and uses `estimate_base_fee`
///
/// # Arguments
/// * `envelope` - The transaction envelope to estimate fees for
/// * `provider` - Stellar provider for simulation (required if simulation is needed)
/// * `operations_override` - Optional override for operations count (useful when operations will be added, e.g., +1 for fee payment)
///
/// # Returns
/// Estimated fee in stroops (XLM)
pub async fn estimate_fee<P>(
    envelope: &TransactionEnvelope,
    provider: &P,
    operations_override: Option<usize>,
) -> Result<u64, StellarTransactionUtilsError>
where
    P: StellarProviderTrait + Send + Sync,
{
    // Check if simulation is needed
    let needs_sim = xdr_needs_simulation(envelope).map_err(|e| {
        StellarTransactionUtilsError::SimulationCheckFailed(format!(
            "Failed to check if simulation is needed: {e}"
        ))
    })?;

    if needs_sim {
        debug!("Transaction contains Soroban operations, simulating to get accurate fee");

        // For simulation, we simulate the envelope as-is
        let simulation_result = provider
            .simulate_transaction_envelope(envelope)
            .await
            .map_err(|e| {
                StellarTransactionUtilsError::SimulationFailed(format!(
                    "Failed to simulate transaction: {e}"
                ))
            })?;

        // Check simulation success
        if simulation_result.results.is_empty() {
            return Err(StellarTransactionUtilsError::SimulationNoResults);
        }

        // Use min_resource_fee from simulation (this includes all fees for Soroban operations)
        // If operations_override is provided, we add the base fee for additional operations
        let resource_fee = simulation_result.min_resource_fee as u64;
        let inclusion_fee = STELLAR_DEFAULT_TRANSACTION_FEE as u64;
        let required_fee = inclusion_fee + resource_fee;

        debug!("Simulation returned fee: {} stroops", required_fee);
        Ok(required_fee)
    } else {
        // No simulation needed, count operations and estimate base fee
        let num_operations = if let Some(override_count) = operations_override {
            override_count
        } else {
            let operations = extract_operations(envelope).map_err(|e| {
                StellarTransactionUtilsError::OperationExtractionFailed(format!(
                    "Failed to extract operations: {e}"
                ))
            })?;
            operations.len()
        };

        let fee = estimate_base_fee(num_operations);
        debug!(
            "No simulation needed, estimated fee from {} operations: {} stroops",
            num_operations, fee
        );
        Ok(fee)
    }
}

/// Convert XLM fee to token amount using DEX service
///
/// This function converts an XLM fee (in stroops) to the equivalent amount in the requested token
/// using the DEX service. For native XLM, no conversion is needed.
/// Optionally applies a fee margin percentage to the XLM fee before conversion.
///
/// # Arguments
/// * `dex_service` - DEX service for token conversion quotes
/// * `policy` - Stellar relayer policy for slippage and token decimals
/// * `xlm_fee` - Fee amount in XLM stroops (already estimated)
/// * `fee_token` - Token identifier (e.g., "native" or "USDC:GA5Z...")
///
/// # Returns
/// A tuple containing:
/// * `FeeQuote` - Fee quote with amounts in both token and XLM
/// * `u64` - Buffered XLM fee (with margin applied if specified)
pub async fn convert_xlm_fee_to_token<D>(
    dex_service: &D,
    policy: &RelayerStellarPolicy,
    xlm_fee: u64,
    fee_token: &str,
) -> Result<FeeQuote, StellarTransactionUtilsError>
where
    D: StellarDexServiceTrait + Send + Sync,
{
    // Handle native XLM - no conversion needed
    if fee_token == "native" || fee_token.is_empty() {
        debug!("Converting XLM fee to native XLM: {}", xlm_fee);
        let buffered_fee = if let Some(margin) = policy.fee_margin_percentage {
            (xlm_fee as f64 * (1.0 + margin as f64 / 100.0)) as u64
        } else {
            xlm_fee
        };

        return Ok(FeeQuote {
            fee_in_token: buffered_fee,
            fee_in_token_ui: amount_to_ui_amount(buffered_fee, 7),
            fee_in_stroops: buffered_fee,
            conversion_rate: 1.0,
        });
    }

    debug!("Converting XLM fee to token: {}", fee_token);

    // Apply fee margin if specified in policy
    let buffered_xlm_fee = if let Some(margin) = policy.fee_margin_percentage {
        (xlm_fee as f64 * (1.0 + margin as f64 / 100.0)) as u64
    } else {
        xlm_fee
    };

    // Get slippage from policy or use default
    let slippage = policy
        .get_allowed_token_entry(fee_token)
        .and_then(|token| {
            token
                .swap_config
                .as_ref()
                .and_then(|config| config.slippage_percentage)
        })
        .or(policy.slippage_percentage)
        .unwrap_or(DEFAULT_CONVERSION_SLIPPAGE_PERCENTAGE);

    // Get quote from DEX service
    // Get token decimals from policy or default to 7
    let token_decimals = policy.get_allowed_token_decimals(fee_token);
    let quote = dex_service
        .get_xlm_to_token_quote(fee_token, buffered_xlm_fee, slippage, token_decimals)
        .await
        .map_err(|e| {
            StellarTransactionUtilsError::DexQuoteFailed(format!("Failed to get quote: {e}"))
        })?;

    debug!(
        "Quote from DEX: input={} stroops XLM, output={} stroops token, input_asset={}, output_asset={}",
        quote.in_amount, quote.out_amount, quote.input_asset, quote.output_asset
    );

    // Calculate conversion rate
    let conversion_rate = if buffered_xlm_fee > 0 {
        quote.out_amount as f64 / buffered_xlm_fee as f64
    } else {
        0.0
    };

    let fee_quote = FeeQuote {
        fee_in_token: quote.out_amount,
        fee_in_token_ui: amount_to_ui_amount(quote.out_amount, token_decimals.unwrap_or(7)),
        fee_in_stroops: buffered_xlm_fee,
        conversion_rate,
    };

    debug!(
        "Final fee quote: fee_in_token={} stroops ({} {}), fee_in_stroops={} stroops XLM, conversion_rate={}",
        fee_quote.fee_in_token, fee_quote.fee_in_token_ui, fee_token, fee_quote.fee_in_stroops, fee_quote.conversion_rate
    );

    Ok(fee_quote)
}

/// Parse transaction envelope from JSON value
pub fn parse_transaction_envelope(
    transaction_json: &serde_json::Value,
) -> Result<TransactionEnvelope, StellarTransactionUtilsError> {
    // Try to parse as XDR string first
    if let Some(xdr_str) = transaction_json.as_str() {
        return TransactionEnvelope::from_xdr_base64(xdr_str, Limits::none()).map_err(|e| {
            StellarTransactionUtilsError::XdrParseFailed(format!("Failed to parse XDR: {e}"))
        });
    }

    // Try to parse as object with transaction_xdr field
    if let Some(obj) = transaction_json.as_object() {
        if let Some(xdr_str) = obj.get("transaction_xdr").and_then(|v| v.as_str()) {
            return TransactionEnvelope::from_xdr_base64(xdr_str, Limits::none()).map_err(|e| {
                StellarTransactionUtilsError::XdrParseFailed(format!("Failed to parse XDR: {e}"))
            });
        }
    }

    Err(StellarTransactionUtilsError::InvalidTransactionFormat(
        "Transaction must be XDR string or object with transaction_xdr field".to_string(),
    ))
}

/// Create fee payment operation
pub fn create_fee_payment_operation(
    destination: &str,
    asset_id: &str,
    amount: i64,
) -> Result<OperationSpec, StellarTransactionUtilsError> {
    // Parse asset identifier
    let asset = if asset_id == "native" || asset_id.is_empty() {
        AssetSpec::Native
    } else {
        // Parse "CODE:ISSUER" format
        if let Some(colon_pos) = asset_id.find(':') {
            let code = asset_id[..colon_pos].to_string();
            let issuer = asset_id[colon_pos + 1..].to_string();

            // Determine if it's Credit4 or Credit12 based on code length
            if code.len() <= 4 {
                AssetSpec::Credit4 { code, issuer }
            } else if code.len() <= 12 {
                AssetSpec::Credit12 { code, issuer }
            } else {
                return Err(StellarTransactionUtilsError::AssetCodeTooLong(
                    12, // Stellar max asset code length
                    code,
                ));
            }
        } else {
            return Err(StellarTransactionUtilsError::InvalidAssetFormat(format!(
                "Invalid asset identifier format. Expected 'native' or 'CODE:ISSUER', got: {asset_id}"
            )));
        }
    };

    Ok(OperationSpec::Payment {
        destination: destination.to_string(),
        amount,
        asset,
    })
}

/// Add operation to transaction envelope
pub fn add_operation_to_envelope(
    envelope: &mut TransactionEnvelope,
    operation: Operation,
) -> Result<(), StellarTransactionUtilsError> {
    match envelope {
        TransactionEnvelope::TxV0(ref mut e) => {
            // Extract existing operations
            let mut ops: Vec<Operation> = e.tx.operations.iter().cloned().collect();
            ops.push(operation);

            // Convert back to VecM
            let operations: VecM<Operation, 100> = ops.try_into().map_err(|_| {
                StellarTransactionUtilsError::TooManyOperations(STELLAR_MAX_OPERATIONS)
            })?;

            e.tx.operations = operations;

            // Update fee to account for new operation
            e.tx.fee = (e.tx.operations.len() as u32) * STELLAR_DEFAULT_TRANSACTION_FEE;
            // 100 stroops per operation
        }
        TransactionEnvelope::Tx(ref mut e) => {
            // Extract existing operations
            let mut ops: Vec<Operation> = e.tx.operations.iter().cloned().collect();
            ops.push(operation);

            // Convert back to VecM
            let operations: VecM<Operation, 100> = ops.try_into().map_err(|_| {
                StellarTransactionUtilsError::TooManyOperations(STELLAR_MAX_OPERATIONS)
            })?;

            e.tx.operations = operations;

            // Update fee to account for new operation
            e.tx.fee = (e.tx.operations.len() as u32) * STELLAR_DEFAULT_TRANSACTION_FEE;
            // 100 stroops per operation
        }
        TransactionEnvelope::TxFeeBump(_) => {
            return Err(StellarTransactionUtilsError::CannotModifyFeeBump);
        }
    }
    Ok(())
}

/// Extract time bounds from a transaction envelope
///
/// Handles both regular transactions (TxV0, Tx) and fee-bump transactions
/// (extracts from inner transaction).
///
/// # Arguments
/// * `envelope` - The transaction envelope to extract time bounds from
///
/// # Returns
/// Some(TimeBounds) if present, None otherwise
pub fn extract_time_bounds(envelope: &TransactionEnvelope) -> Option<&TimeBounds> {
    match envelope {
        TransactionEnvelope::TxV0(e) => e.tx.time_bounds.as_ref(),
        TransactionEnvelope::Tx(e) => match &e.tx.cond {
            Preconditions::Time(tb) => Some(tb),
            Preconditions::V2(v2) => v2.time_bounds.as_ref(),
            Preconditions::None => None,
        },
        TransactionEnvelope::TxFeeBump(fb) => {
            // Extract from inner transaction
            match &fb.tx.inner_tx {
                soroban_rs::xdr::FeeBumpTransactionInnerTx::Tx(inner_tx) => {
                    match &inner_tx.tx.cond {
                        Preconditions::Time(tb) => Some(tb),
                        Preconditions::V2(v2) => v2.time_bounds.as_ref(),
                        Preconditions::None => None,
                    }
                }
            }
        }
    }
}

/// Set time bounds on transaction envelope
pub fn set_time_bounds(
    envelope: &mut TransactionEnvelope,
    valid_until: DateTime<Utc>,
) -> Result<(), StellarTransactionUtilsError> {
    let max_time = valid_until.timestamp() as u64;
    let time_bounds = TimeBounds {
        min_time: TimePoint(0),
        max_time: TimePoint(max_time),
    };

    match envelope {
        TransactionEnvelope::TxV0(ref mut e) => {
            e.tx.time_bounds = Some(time_bounds);
        }
        TransactionEnvelope::Tx(ref mut e) => {
            e.tx.cond = Preconditions::Time(time_bounds);
        }
        TransactionEnvelope::TxFeeBump(_) => {
            return Err(StellarTransactionUtilsError::CannotSetTimeBoundsOnFeeBump);
        }
    }
    Ok(())
}

/// Extract asset identifier from CreditAlphanum4
fn credit_alphanum4_to_asset_id(
    alpha4: &AlphaNum4,
) -> Result<String, StellarTransactionUtilsError> {
    // Extract code (trim null bytes)
    let code_bytes = alpha4.asset_code.0;
    let code_len = code_bytes.iter().position(|&b| b == 0).unwrap_or(4);
    let code = String::from_utf8(code_bytes[..code_len].to_vec()).map_err(|e| {
        StellarTransactionUtilsError::InvalidAssetFormat(format!("Invalid asset code: {e}"))
    })?;

    // Extract issuer
    let issuer = match &alpha4.issuer.0 {
        XdrPublicKey::PublicKeyTypeEd25519(uint256) => {
            let bytes: [u8; 32] = uint256.0;
            let pk = PublicKey(bytes);
            pk.to_string()
        }
    };

    Ok(format!("{code}:{issuer}"))
}

/// Extract asset identifier from CreditAlphanum12
fn credit_alphanum12_to_asset_id(
    alpha12: &AlphaNum12,
) -> Result<String, StellarTransactionUtilsError> {
    // Extract code (trim null bytes)
    let code_bytes = alpha12.asset_code.0;
    let code_len = code_bytes.iter().position(|&b| b == 0).unwrap_or(12);
    let code = String::from_utf8(code_bytes[..code_len].to_vec()).map_err(|e| {
        StellarTransactionUtilsError::InvalidAssetFormat(format!("Invalid asset code: {e}"))
    })?;

    // Extract issuer
    let issuer = match &alpha12.issuer.0 {
        XdrPublicKey::PublicKeyTypeEd25519(uint256) => {
            let bytes: [u8; 32] = uint256.0;
            let pk = PublicKey(bytes);
            pk.to_string()
        }
    };

    Ok(format!("{code}:{issuer}"))
}

/// Convert ChangeTrustAsset XDR to asset identifier string
///
/// Returns `Some(asset_id)` for CreditAlphanum4 and CreditAlphanum12 assets,
/// or `None` for Native or PoolShare (which don't have asset identifiers).
///
/// # Arguments
///
/// * `change_trust_asset` - The ChangeTrustAsset to convert
///
/// # Returns
///
/// Asset identifier string in "CODE:ISSUER" format, or None for Native/PoolShare
pub fn change_trust_asset_to_asset_id(
    change_trust_asset: &ChangeTrustAsset,
) -> Result<Option<String>, StellarTransactionUtilsError> {
    match change_trust_asset {
        ChangeTrustAsset::Native | ChangeTrustAsset::PoolShare(_) => Ok(None),
        ChangeTrustAsset::CreditAlphanum4(alpha4) => {
            // Convert to Asset and use the unified function
            let asset = Asset::CreditAlphanum4(alpha4.clone());
            asset_to_asset_id(&asset).map(Some)
        }
        ChangeTrustAsset::CreditAlphanum12(alpha12) => {
            // Convert to Asset and use the unified function
            let asset = Asset::CreditAlphanum12(alpha12.clone());
            asset_to_asset_id(&asset).map(Some)
        }
    }
}

/// Convert Asset XDR to asset identifier string
///
/// # Arguments
///
/// * `asset` - The Asset to convert
///
/// # Returns
///
/// Asset identifier string ("native" for Native, or "CODE:ISSUER" for credit assets)
pub fn asset_to_asset_id(asset: &Asset) -> Result<String, StellarTransactionUtilsError> {
    match asset {
        Asset::Native => Ok("native".to_string()),
        Asset::CreditAlphanum4(alpha4) => credit_alphanum4_to_asset_id(alpha4),
        Asset::CreditAlphanum12(alpha12) => credit_alphanum12_to_asset_id(alpha12),
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::domain::transaction::stellar::test_helpers::TEST_PK;
    use crate::models::AssetSpec;
    use crate::models::{AuthSpec, ContractSource, WasmSource};

    fn payment_op(destination: &str) -> OperationSpec {
        OperationSpec::Payment {
            destination: destination.to_string(),
            amount: 100,
            asset: AssetSpec::Native,
        }
    }

    #[test]
    fn returns_false_for_only_payment_ops() {
        let ops = vec![payment_op(TEST_PK)];
        assert!(!needs_simulation(&ops));
    }

    #[test]
    fn returns_true_for_invoke_contract_ops() {
        let ops = vec![OperationSpec::InvokeContract {
            contract_address: "CA7QYNF7SOWQ3GLR2BGMZEHXAVIRZA4KVWLTJJFC7MGXUA74P7UJUWDA"
                .to_string(),
            function_name: "transfer".to_string(),
            args: vec![],
            auth: None,
        }];
        assert!(needs_simulation(&ops));
    }

    #[test]
    fn returns_true_for_upload_wasm_ops() {
        let ops = vec![OperationSpec::UploadWasm {
            wasm: WasmSource::Hex {
                hex: "deadbeef".to_string(),
            },
            auth: None,
        }];
        assert!(needs_simulation(&ops));
    }

    #[test]
    fn returns_true_for_create_contract_ops() {
        let ops = vec![OperationSpec::CreateContract {
            source: ContractSource::Address {
                address: TEST_PK.to_string(),
            },
            wasm_hash: "0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef"
                .to_string(),
            salt: None,
            constructor_args: None,
            auth: None,
        }];
        assert!(needs_simulation(&ops));
    }

    #[test]
    fn returns_true_for_single_invoke_host_function() {
        let ops = vec![OperationSpec::InvokeContract {
            contract_address: "CA7QYNF7SOWQ3GLR2BGMZEHXAVIRZA4KVWLTJJFC7MGXUA74P7UJUWDA"
                .to_string(),
            function_name: "transfer".to_string(),
            args: vec![],
            auth: Some(AuthSpec::SourceAccount),
        }];
        assert!(needs_simulation(&ops));
    }

    #[test]
    fn returns_false_for_multiple_payment_ops() {
        let ops = vec![payment_op(TEST_PK), payment_op(TEST_PK)];
        assert!(!needs_simulation(&ops));
    }

    mod next_sequence_u64_tests {
        use super::*;

        #[test]
        fn test_increment() {
            assert_eq!(next_sequence_u64(0).unwrap(), 1);

            assert_eq!(next_sequence_u64(12345).unwrap(), 12346);
        }

        #[test]
        fn test_error_path_overflow_i64_max() {
            let result = next_sequence_u64(i64::MAX);
            assert!(result.is_err());
            match result.unwrap_err() {
                RelayerError::ProviderError(msg) => assert_eq!(msg, "sequence overflow"),
                _ => panic!("Unexpected error type"),
            }
        }
    }

    mod i64_from_u64_tests {
        use super::*;

        #[test]
        fn test_happy_path_conversion() {
            assert_eq!(i64_from_u64(0).unwrap(), 0);
            assert_eq!(i64_from_u64(12345).unwrap(), 12345);
            assert_eq!(i64_from_u64(i64::MAX as u64).unwrap(), i64::MAX);
        }

        #[test]
        fn test_error_path_overflow_u64_max() {
            let result = i64_from_u64(u64::MAX);
            assert!(result.is_err());
            match result.unwrap_err() {
                RelayerError::ProviderError(msg) => assert_eq!(msg, "u64→i64 overflow"),
                _ => panic!("Unexpected error type"),
            }
        }

        #[test]
        fn test_edge_case_just_above_i64_max() {
            // Smallest u64 value that will overflow i64
            let value = (i64::MAX as u64) + 1;
            let result = i64_from_u64(value);
            assert!(result.is_err());
            match result.unwrap_err() {
                RelayerError::ProviderError(msg) => assert_eq!(msg, "u64→i64 overflow"),
                _ => panic!("Unexpected error type"),
            }
        }
    }

    mod is_bad_sequence_error_tests {
        use super::*;

        #[test]
        fn test_detects_txbadseq() {
            assert!(is_bad_sequence_error(
                "Failed to send transaction: transaction submission failed: TxBadSeq"
            ));
            assert!(is_bad_sequence_error("Error: TxBadSeq"));
            assert!(is_bad_sequence_error("txbadseq"));
            assert!(is_bad_sequence_error("TXBADSEQ"));
        }

        #[test]
        fn test_returns_false_for_other_errors() {
            assert!(!is_bad_sequence_error("network timeout"));
            assert!(!is_bad_sequence_error("insufficient balance"));
            assert!(!is_bad_sequence_error("tx_insufficient_fee"));
            assert!(!is_bad_sequence_error("bad_auth"));
            assert!(!is_bad_sequence_error(""));
        }
    }

    mod status_check_utils_tests {
        use crate::models::{
            NetworkTransactionData, StellarTransactionData, TransactionError, TransactionInput,
            TransactionRepoModel,
        };
        use crate::utils::mocks::mockutils::create_mock_transaction;
        use chrono::{Duration, Utc};

        /// Helper to create a test transaction with a specific created_at timestamp
        fn create_test_tx_with_age(seconds_ago: i64) -> TransactionRepoModel {
            let created_at = (Utc::now() - Duration::seconds(seconds_ago)).to_rfc3339();
            let mut tx = create_mock_transaction();
            tx.id = format!("test-tx-{}", seconds_ago);
            tx.created_at = created_at;
            tx.network_data = NetworkTransactionData::Stellar(StellarTransactionData {
                source_account: "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF"
                    .to_string(),
                fee: None,
                sequence_number: None,
                memo: None,
                valid_until: None,
                network_passphrase: "Test SDF Network ; September 2015".to_string(),
                signatures: vec![],
                hash: Some("test-hash-12345".to_string()),
                simulation_transaction_data: None,
                transaction_input: TransactionInput::Operations(vec![]),
                signed_envelope_xdr: None,
                transaction_result_xdr: None,
            });
            tx
        }

        mod get_age_since_created_tests {
            use crate::domain::transaction::util::get_age_since_created;

            use super::*;

            #[test]
            fn test_returns_correct_age_for_recent_transaction() {
                let tx = create_test_tx_with_age(30); // 30 seconds ago
                let age = get_age_since_created(&tx).unwrap();

                // Allow for small timing differences (within 1 second)
                assert!(age.num_seconds() >= 29 && age.num_seconds() <= 31);
            }

            #[test]
            fn test_returns_correct_age_for_old_transaction() {
                let tx = create_test_tx_with_age(3600); // 1 hour ago
                let age = get_age_since_created(&tx).unwrap();

                // Allow for small timing differences
                assert!(age.num_seconds() >= 3599 && age.num_seconds() <= 3601);
            }

            #[test]
            fn test_returns_zero_age_for_just_created_transaction() {
                let tx = create_test_tx_with_age(0); // Just now
                let age = get_age_since_created(&tx).unwrap();

                // Should be very close to 0
                assert!(age.num_seconds() >= 0 && age.num_seconds() <= 1);
            }

            #[test]
            fn test_handles_negative_age_gracefully() {
                // Create transaction with future timestamp (clock skew scenario)
                let created_at = (Utc::now() + Duration::seconds(10)).to_rfc3339();
                let mut tx = create_mock_transaction();
                tx.created_at = created_at;

                let age = get_age_since_created(&tx).unwrap();

                // Age should be negative
                assert!(age.num_seconds() < 0);
            }

            #[test]
            fn test_returns_error_for_invalid_created_at() {
                let mut tx = create_mock_transaction();
                tx.created_at = "invalid-timestamp".to_string();

                let result = get_age_since_created(&tx);
                assert!(result.is_err());

                match result.unwrap_err() {
                    TransactionError::UnexpectedError(msg) => {
                        assert!(msg.contains("Invalid created_at timestamp"));
                    }
                    _ => panic!("Expected UnexpectedError"),
                }
            }

            #[test]
            fn test_returns_error_for_empty_created_at() {
                let mut tx = create_mock_transaction();
                tx.created_at = "".to_string();

                let result = get_age_since_created(&tx);
                assert!(result.is_err());
            }

            #[test]
            fn test_handles_various_rfc3339_formats() {
                let mut tx = create_mock_transaction();

                // Test with UTC timezone
                tx.created_at = "2025-01-01T12:00:00Z".to_string();
                assert!(get_age_since_created(&tx).is_ok());

                // Test with offset timezone
                tx.created_at = "2025-01-01T12:00:00+00:00".to_string();
                assert!(get_age_since_created(&tx).is_ok());

                // Test with milliseconds
                tx.created_at = "2025-01-01T12:00:00.123Z".to_string();
                assert!(get_age_since_created(&tx).is_ok());
            }
        }
    }

    #[test]
    fn test_create_signature_payload_functions() {
        use soroban_rs::xdr::{
            Hash, SequenceNumber, TransactionEnvelope, TransactionV0, TransactionV0Envelope,
            Uint256,
        };

        // Test create_transaction_signature_payload
        let transaction = soroban_rs::xdr::Transaction {
            source_account: soroban_rs::xdr::MuxedAccount::Ed25519(Uint256([1u8; 32])),
            fee: 100,
            seq_num: SequenceNumber(123),
            cond: soroban_rs::xdr::Preconditions::None,
            memo: soroban_rs::xdr::Memo::None,
            operations: vec![].try_into().unwrap(),
            ext: soroban_rs::xdr::TransactionExt::V0,
        };
        let network_id = Hash([2u8; 32]);

        let payload = create_transaction_signature_payload(&transaction, &network_id);
        assert_eq!(payload.network_id, network_id);

        // Test create_signature_payload with V0 envelope
        let v0_tx = TransactionV0 {
            source_account_ed25519: Uint256([1u8; 32]),
            fee: 100,
            seq_num: SequenceNumber(123),
            time_bounds: None,
            memo: soroban_rs::xdr::Memo::None,
            operations: vec![].try_into().unwrap(),
            ext: soroban_rs::xdr::TransactionV0Ext::V0,
        };
        let v0_envelope = TransactionEnvelope::TxV0(TransactionV0Envelope {
            tx: v0_tx,
            signatures: vec![].try_into().unwrap(),
        });

        let v0_payload = create_signature_payload(&v0_envelope, &network_id).unwrap();
        assert_eq!(v0_payload.network_id, network_id);
    }

    mod convert_v0_to_v1_transaction_tests {
        use super::*;
        use soroban_rs::xdr::{SequenceNumber, TransactionV0, Uint256};

        #[test]
        fn test_convert_v0_to_v1_transaction() {
            // Create a simple V0 transaction
            let v0_tx = TransactionV0 {
                source_account_ed25519: Uint256([1u8; 32]),
                fee: 100,
                seq_num: SequenceNumber(123),
                time_bounds: None,
                memo: soroban_rs::xdr::Memo::None,
                operations: vec![].try_into().unwrap(),
                ext: soroban_rs::xdr::TransactionV0Ext::V0,
            };

            // Convert to V1
            let v1_tx = convert_v0_to_v1_transaction(&v0_tx);

            // Check that conversion worked correctly
            assert_eq!(v1_tx.fee, v0_tx.fee);
            assert_eq!(v1_tx.seq_num, v0_tx.seq_num);
            assert_eq!(v1_tx.memo, v0_tx.memo);
            assert_eq!(v1_tx.operations, v0_tx.operations);
            assert!(matches!(v1_tx.ext, soroban_rs::xdr::TransactionExt::V0));
            assert!(matches!(v1_tx.cond, soroban_rs::xdr::Preconditions::None));

            // Check source account conversion
            match v1_tx.source_account {
                soroban_rs::xdr::MuxedAccount::Ed25519(addr) => {
                    assert_eq!(addr, v0_tx.source_account_ed25519);
                }
                _ => panic!("Expected Ed25519 muxed account"),
            }
        }

        #[test]
        fn test_convert_v0_to_v1_transaction_with_time_bounds() {
            // Create a V0 transaction with time bounds
            let time_bounds = soroban_rs::xdr::TimeBounds {
                min_time: soroban_rs::xdr::TimePoint(100),
                max_time: soroban_rs::xdr::TimePoint(200),
            };

            let v0_tx = TransactionV0 {
                source_account_ed25519: Uint256([2u8; 32]),
                fee: 200,
                seq_num: SequenceNumber(456),
                time_bounds: Some(time_bounds.clone()),
                memo: soroban_rs::xdr::Memo::Text("test".try_into().unwrap()),
                operations: vec![].try_into().unwrap(),
                ext: soroban_rs::xdr::TransactionV0Ext::V0,
            };

            // Convert to V1
            let v1_tx = convert_v0_to_v1_transaction(&v0_tx);

            // Check that time bounds were correctly converted to preconditions
            match v1_tx.cond {
                soroban_rs::xdr::Preconditions::Time(tb) => {
                    assert_eq!(tb, time_bounds);
                }
                _ => panic!("Expected Time preconditions"),
            }
        }
    }
}

#[cfg(test)]
mod parse_contract_address_tests {
    use super::*;
    use crate::domain::transaction::stellar::test_helpers::{
        TEST_CONTRACT, TEST_PK as TEST_ACCOUNT,
    };

    #[test]
    fn test_parse_valid_contract_address() {
        let result = parse_contract_address(TEST_CONTRACT);
        assert!(result.is_ok());

        let hash = result.unwrap();
        assert_eq!(hash.0.len(), 32);
    }

    #[test]
    fn test_parse_invalid_contract_address() {
        let result = parse_contract_address("INVALID_CONTRACT");
        assert!(result.is_err());

        match result.unwrap_err() {
            StellarTransactionUtilsError::InvalidContractAddress(addr, _) => {
                assert_eq!(addr, "INVALID_CONTRACT");
            }
            _ => panic!("Expected InvalidContractAddress error"),
        }
    }

    #[test]
    fn test_parse_contract_address_wrong_prefix() {
        // Try with an account address instead of contract
        let result = parse_contract_address(TEST_ACCOUNT);
        assert!(result.is_err());
    }

    #[test]
    fn test_parse_empty_contract_address() {
        let result = parse_contract_address("");
        assert!(result.is_err());
    }
}

// ============================================================================
// Update Envelope Sequence and Envelope Fee Tests
// ============================================================================

#[cfg(test)]
mod update_envelope_sequence_tests {
    use super::*;
    use soroban_rs::xdr::{
        FeeBumpTransaction, FeeBumpTransactionEnvelope, FeeBumpTransactionExt,
        FeeBumpTransactionInnerTx, Memo, MuxedAccount, Preconditions, SequenceNumber, Transaction,
        TransactionExt, TransactionV0, TransactionV0Envelope, TransactionV0Ext,
        TransactionV1Envelope, Uint256, VecM,
    };

    fn create_minimal_v1_envelope() -> TransactionEnvelope {
        let tx = Transaction {
            source_account: MuxedAccount::Ed25519(Uint256([0u8; 32])),
            fee: 100,
            seq_num: SequenceNumber(0),
            cond: Preconditions::None,
            memo: Memo::None,
            operations: VecM::default(),
            ext: TransactionExt::V0,
        };
        TransactionEnvelope::Tx(TransactionV1Envelope {
            tx,
            signatures: VecM::default(),
        })
    }

    fn create_v0_envelope() -> TransactionEnvelope {
        let tx = TransactionV0 {
            source_account_ed25519: Uint256([0u8; 32]),
            fee: 100,
            seq_num: SequenceNumber(0),
            time_bounds: None,
            memo: Memo::None,
            operations: VecM::default(),
            ext: TransactionV0Ext::V0,
        };
        TransactionEnvelope::TxV0(TransactionV0Envelope {
            tx,
            signatures: VecM::default(),
        })
    }

    fn create_fee_bump_envelope() -> TransactionEnvelope {
        let inner_tx = Transaction {
            source_account: MuxedAccount::Ed25519(Uint256([0u8; 32])),
            fee: 100,
            seq_num: SequenceNumber(0),
            cond: Preconditions::None,
            memo: Memo::None,
            operations: VecM::default(),
            ext: TransactionExt::V0,
        };
        let inner_envelope = TransactionV1Envelope {
            tx: inner_tx,
            signatures: VecM::default(),
        };
        let fee_bump_tx = FeeBumpTransaction {
            fee_source: MuxedAccount::Ed25519(Uint256([1u8; 32])),
            fee: 200,
            inner_tx: FeeBumpTransactionInnerTx::Tx(inner_envelope),
            ext: FeeBumpTransactionExt::V0,
        };
        TransactionEnvelope::TxFeeBump(FeeBumpTransactionEnvelope {
            tx: fee_bump_tx,
            signatures: VecM::default(),
        })
    }

    #[test]
    fn test_update_envelope_sequence() {
        let mut envelope = create_minimal_v1_envelope();
        update_envelope_sequence(&mut envelope, 12345).unwrap();
        if let TransactionEnvelope::Tx(v1) = &envelope {
            assert_eq!(v1.tx.seq_num.0, 12345);
        } else {
            panic!("Expected Tx envelope");
        }
    }

    #[test]
    fn test_update_envelope_sequence_v0_returns_error() {
        let mut envelope = create_v0_envelope();
        let result = update_envelope_sequence(&mut envelope, 12345);
        assert!(result.is_err());
        match result.unwrap_err() {
            StellarTransactionUtilsError::V0TransactionsNotSupported => {}
            _ => panic!("Expected V0TransactionsNotSupported error"),
        }
    }

    #[test]
    fn test_update_envelope_sequence_fee_bump_returns_error() {
        let mut envelope = create_fee_bump_envelope();
        let result = update_envelope_sequence(&mut envelope, 12345);
        assert!(result.is_err());
        match result.unwrap_err() {
            StellarTransactionUtilsError::CannotUpdateSequenceOnFeeBump => {}
            _ => panic!("Expected CannotUpdateSequenceOnFeeBump error"),
        }
    }

    #[test]
    fn test_update_envelope_sequence_zero() {
        let mut envelope = create_minimal_v1_envelope();
        update_envelope_sequence(&mut envelope, 0).unwrap();
        if let TransactionEnvelope::Tx(v1) = &envelope {
            assert_eq!(v1.tx.seq_num.0, 0);
        } else {
            panic!("Expected Tx envelope");
        }
    }

    #[test]
    fn test_update_envelope_sequence_max_value() {
        let mut envelope = create_minimal_v1_envelope();
        update_envelope_sequence(&mut envelope, i64::MAX).unwrap();
        if let TransactionEnvelope::Tx(v1) = &envelope {
            assert_eq!(v1.tx.seq_num.0, i64::MAX);
        } else {
            panic!("Expected Tx envelope");
        }
    }

    #[test]
    fn test_envelope_fee_in_stroops_v1() {
        let envelope = create_minimal_v1_envelope();
        let fee = envelope_fee_in_stroops(&envelope).unwrap();
        assert_eq!(fee, 100);
    }

    #[test]
    fn test_envelope_fee_in_stroops_v0_returns_error() {
        let envelope = create_v0_envelope();
        let result = envelope_fee_in_stroops(&envelope);
        assert!(result.is_err());
        match result.unwrap_err() {
            StellarTransactionUtilsError::InvalidTransactionFormat(msg) => {
                assert!(msg.contains("Expected V1"));
            }
            _ => panic!("Expected InvalidTransactionFormat error"),
        }
    }

    #[test]
    fn test_envelope_fee_in_stroops_fee_bump_returns_error() {
        let envelope = create_fee_bump_envelope();
        let result = envelope_fee_in_stroops(&envelope);
        assert!(result.is_err());
    }
}

// ============================================================================
// Contract Data Key Tests
// ============================================================================

#[cfg(test)]
mod create_contract_data_key_tests {
    use super::*;
    use crate::domain::transaction::stellar::test_helpers::TEST_PK as TEST_ACCOUNT;
    use stellar_strkey::ed25519::PublicKey;

    #[test]
    fn test_create_key_without_address() {
        let result = create_contract_data_key("Balance", None);
        assert!(result.is_ok());

        match result.unwrap() {
            ScVal::Symbol(sym) => {
                assert_eq!(sym.to_string(), "Balance");
            }
            _ => panic!("Expected Symbol ScVal"),
        }
    }

    #[test]
    fn test_create_key_with_address() {
        let pk = PublicKey::from_string(TEST_ACCOUNT).unwrap();
        let uint256 = Uint256(pk.0);
        let account_id = AccountId(soroban_rs::xdr::PublicKey::PublicKeyTypeEd25519(uint256));
        let sc_address = ScAddress::Account(account_id);

        let result = create_contract_data_key("Balance", Some(sc_address.clone()));
        assert!(result.is_ok());

        match result.unwrap() {
            ScVal::Vec(Some(vec)) => {
                assert_eq!(vec.0.len(), 2);
                match &vec.0[0] {
                    ScVal::Symbol(sym) => assert_eq!(sym.to_string(), "Balance"),
                    _ => panic!("Expected Symbol as first element"),
                }
                match &vec.0[1] {
                    ScVal::Address(addr) => assert_eq!(addr, &sc_address),
                    _ => panic!("Expected Address as second element"),
                }
            }
            _ => panic!("Expected Vec ScVal"),
        }
    }

    #[test]
    fn test_create_key_invalid_symbol() {
        // Test with symbol that's too long or has invalid characters
        let very_long_symbol = "a".repeat(100);
        let result = create_contract_data_key(&very_long_symbol, None);
        assert!(result.is_err());

        match result.unwrap_err() {
            StellarTransactionUtilsError::SymbolCreationFailed(_, _) => {}
            _ => panic!("Expected SymbolCreationFailed error"),
        }
    }

    #[test]
    fn test_create_key_decimals() {
        let result = create_contract_data_key("Decimals", None);
        assert!(result.is_ok());
    }
}

// ============================================================================
// Extract ScVal from Contract Data Tests
// ============================================================================

#[cfg(test)]
mod extract_scval_from_contract_data_tests {
    use super::*;
    use soroban_rs::stellar_rpc_client::{GetLedgerEntriesResponse, LedgerEntryResult};
    use soroban_rs::xdr::{
        ContractDataDurability, ContractDataEntry, ExtensionPoint, Hash, LedgerEntry,
        LedgerEntryData, LedgerEntryExt, ScSymbol, ScVal, WriteXdr,
    };

    #[test]
    fn test_extract_scval_success() {
        let contract_data = ContractDataEntry {
            ext: ExtensionPoint::V0,
            contract: ScAddress::Contract(ContractId(Hash([0u8; 32]))),
            key: ScVal::Symbol(ScSymbol::try_from("test").unwrap()),
            durability: ContractDataDurability::Persistent,
            val: ScVal::U32(42),
        };

        let ledger_entry = LedgerEntry {
            last_modified_ledger_seq: 100,
            data: LedgerEntryData::ContractData(contract_data),
            ext: LedgerEntryExt::V0,
        };

        let xdr = ledger_entry
            .data
            .to_xdr_base64(soroban_rs::xdr::Limits::none())
            .unwrap();

        let response = GetLedgerEntriesResponse {
            entries: Some(vec![LedgerEntryResult {
                key: "test_key".to_string(),
                xdr,
                last_modified_ledger: 100,
                live_until_ledger_seq_ledger_seq: None,
            }]),
            latest_ledger: 100,
        };

        let result = extract_scval_from_contract_data(&response, "test");
        assert!(result.is_ok());

        match result.unwrap() {
            ScVal::U32(val) => assert_eq!(val, 42),
            _ => panic!("Expected U32 ScVal"),
        }
    }

    #[test]
    fn test_extract_scval_no_entries() {
        let response = GetLedgerEntriesResponse {
            entries: None,
            latest_ledger: 100,
        };

        let result = extract_scval_from_contract_data(&response, "test");
        assert!(result.is_err());

        match result.unwrap_err() {
            StellarTransactionUtilsError::NoEntriesFound(_) => {}
            _ => panic!("Expected NoEntriesFound error"),
        }
    }

    #[test]
    fn test_extract_scval_empty_entries() {
        let response = GetLedgerEntriesResponse {
            entries: Some(vec![]),
            latest_ledger: 100,
        };

        let result = extract_scval_from_contract_data(&response, "test");
        assert!(result.is_err());

        match result.unwrap_err() {
            StellarTransactionUtilsError::EmptyEntries(_) => {}
            _ => panic!("Expected EmptyEntries error"),
        }
    }
}

// ============================================================================
// Extract u32 from ScVal Tests
// ============================================================================

#[cfg(test)]
mod extract_u32_from_scval_tests {
    use super::*;
    use soroban_rs::xdr::{Int128Parts, ScVal, UInt128Parts};

    #[test]
    fn test_extract_from_u32() {
        let val = ScVal::U32(42);
        assert_eq!(extract_u32_from_scval(&val, "test"), Some(42));
    }

    #[test]
    fn test_extract_from_i32_positive() {
        let val = ScVal::I32(100);
        assert_eq!(extract_u32_from_scval(&val, "test"), Some(100));
    }

    #[test]
    fn test_extract_from_i32_negative() {
        let val = ScVal::I32(-1);
        assert_eq!(extract_u32_from_scval(&val, "test"), None);
    }

    #[test]
    fn test_extract_from_u64() {
        let val = ScVal::U64(1000);
        assert_eq!(extract_u32_from_scval(&val, "test"), Some(1000));
    }

    #[test]
    fn test_extract_from_u64_overflow() {
        let val = ScVal::U64(u64::MAX);
        assert_eq!(extract_u32_from_scval(&val, "test"), None);
    }

    #[test]
    fn test_extract_from_i64_positive() {
        let val = ScVal::I64(500);
        assert_eq!(extract_u32_from_scval(&val, "test"), Some(500));
    }

    #[test]
    fn test_extract_from_i64_negative() {
        let val = ScVal::I64(-500);
        assert_eq!(extract_u32_from_scval(&val, "test"), None);
    }

    #[test]
    fn test_extract_from_u128_small() {
        let val = ScVal::U128(UInt128Parts { hi: 0, lo: 255 });
        assert_eq!(extract_u32_from_scval(&val, "test"), Some(255));
    }

    #[test]
    fn test_extract_from_u128_hi_set() {
        let val = ScVal::U128(UInt128Parts { hi: 1, lo: 0 });
        assert_eq!(extract_u32_from_scval(&val, "test"), None);
    }

    #[test]
    fn test_extract_from_i128_small() {
        let val = ScVal::I128(Int128Parts { hi: 0, lo: 123 });
        assert_eq!(extract_u32_from_scval(&val, "test"), Some(123));
    }

    #[test]
    fn test_extract_from_unsupported_type() {
        let val = ScVal::Bool(true);
        assert_eq!(extract_u32_from_scval(&val, "test"), None);
    }
}

// ============================================================================
// Amount to UI Amount Tests
// ============================================================================

#[cfg(test)]
mod amount_to_ui_amount_tests {
    use super::*;

    #[test]
    fn test_zero_decimals() {
        assert_eq!(amount_to_ui_amount(100, 0), "100");
        assert_eq!(amount_to_ui_amount(0, 0), "0");
    }

    #[test]
    fn test_with_decimals_no_padding() {
        assert_eq!(amount_to_ui_amount(1000000, 6), "1");
        assert_eq!(amount_to_ui_amount(1500000, 6), "1.5");
        assert_eq!(amount_to_ui_amount(1234567, 6), "1.234567");
    }

    #[test]
    fn test_with_decimals_needs_padding() {
        assert_eq!(amount_to_ui_amount(1, 6), "0.000001");
        assert_eq!(amount_to_ui_amount(100, 6), "0.0001");
        assert_eq!(amount_to_ui_amount(1000, 3), "1");
    }

    #[test]
    fn test_trailing_zeros_removed() {
        assert_eq!(amount_to_ui_amount(1000000, 6), "1");
        assert_eq!(amount_to_ui_amount(1500000, 7), "0.15");
        assert_eq!(amount_to_ui_amount(10000000, 7), "1");
    }

    #[test]
    fn test_zero_amount() {
        assert_eq!(amount_to_ui_amount(0, 6), "0");
        assert_eq!(amount_to_ui_amount(0, 0), "0");
    }

    #[test]
    fn test_xlm_7_decimals() {
        assert_eq!(amount_to_ui_amount(10000000, 7), "1");
        assert_eq!(amount_to_ui_amount(15000000, 7), "1.5");
        assert_eq!(amount_to_ui_amount(100, 7), "0.00001");
    }
}

// // ============================================================================
// // Count Operations Tests
// // ============================================================================

// #[cfg(test)]
#[cfg(test)]
mod count_operations_tests {
    use super::*;
    use soroban_rs::xdr::{
        Limits, MuxedAccount, Operation, OperationBody, PaymentOp, TransactionV1Envelope, Uint256,
        WriteXdr,
    };

    #[test]
    fn test_count_operations_from_xdr() {
        use soroban_rs::xdr::{Memo, Preconditions, SequenceNumber, Transaction, TransactionExt};

        // Create two payment operations
        let payment_op = Operation {
            source_account: None,
            body: OperationBody::Payment(PaymentOp {
                destination: MuxedAccount::Ed25519(Uint256([1u8; 32])),
                asset: Asset::Native,
                amount: 100,
            }),
        };

        let operations = vec![payment_op.clone(), payment_op].try_into().unwrap();

        let tx = Transaction {
            source_account: MuxedAccount::Ed25519(Uint256([0u8; 32])),
            fee: 100,
            seq_num: SequenceNumber(1),
            cond: Preconditions::None,
            memo: Memo::None,
            operations,
            ext: TransactionExt::V0,
        };

        let envelope = TransactionEnvelope::Tx(TransactionV1Envelope {
            tx,
            signatures: vec![].try_into().unwrap(),
        });

        let xdr = envelope.to_xdr_base64(Limits::none()).unwrap();
        let count = count_operations_from_xdr(&xdr).unwrap();

        assert_eq!(count, 2);
    }

    #[test]
    fn test_count_operations_invalid_xdr() {
        let result = count_operations_from_xdr("invalid_xdr");
        assert!(result.is_err());

        match result.unwrap_err() {
            StellarTransactionUtilsError::XdrParseFailed(_) => {}
            _ => panic!("Expected XdrParseFailed error"),
        }
    }
}

// ============================================================================
// Estimate Base Fee Tests
// ============================================================================

#[cfg(test)]
mod estimate_base_fee_tests {
    use super::*;

    #[test]
    fn test_single_operation() {
        assert_eq!(estimate_base_fee(1), 100);
    }

    #[test]
    fn test_multiple_operations() {
        assert_eq!(estimate_base_fee(5), 500);
        assert_eq!(estimate_base_fee(10), 1000);
    }

    #[test]
    fn test_zero_operations() {
        // Should return fee for at least 1 operation
        assert_eq!(estimate_base_fee(0), 100);
    }

    #[test]
    fn test_large_number_of_operations() {
        assert_eq!(estimate_base_fee(100), 10000);
    }
}

// ============================================================================
// Create Fee Payment Operation Tests
// ============================================================================

#[cfg(test)]
mod create_fee_payment_operation_tests {
    use super::*;
    use crate::domain::transaction::stellar::test_helpers::TEST_PK as TEST_ACCOUNT;

    #[test]
    fn test_create_native_payment() {
        let result = create_fee_payment_operation(TEST_ACCOUNT, "native", 1000);
        assert!(result.is_ok());

        match result.unwrap() {
            OperationSpec::Payment {
                destination,
                amount,
                asset,
            } => {
                assert_eq!(destination, TEST_ACCOUNT);
                assert_eq!(amount, 1000);
                assert!(matches!(asset, AssetSpec::Native));
            }
            _ => panic!("Expected Payment operation"),
        }
    }

    #[test]
    fn test_create_credit4_payment() {
        let result = create_fee_payment_operation(
            TEST_ACCOUNT,
            "USDC:GBBD47IF6LWK7P7MDEVSCWR7DPUWV3NY3DTQEVFL4NAT4AQH3ZLLFLA5",
            5000,
        );
        assert!(result.is_ok());

        match result.unwrap() {
            OperationSpec::Payment {
                destination,
                amount,
                asset,
            } => {
                assert_eq!(destination, TEST_ACCOUNT);
                assert_eq!(amount, 5000);
                match asset {
                    AssetSpec::Credit4 { code, issuer } => {
                        assert_eq!(code, "USDC");
                        assert_eq!(
                            issuer,
                            "GBBD47IF6LWK7P7MDEVSCWR7DPUWV3NY3DTQEVFL4NAT4AQH3ZLLFLA5"
                        );
                    }
                    _ => panic!("Expected Credit4 asset"),
                }
            }
            _ => panic!("Expected Payment operation"),
        }
    }

    #[test]
    fn test_create_credit12_payment() {
        let result = create_fee_payment_operation(
            TEST_ACCOUNT,
            "LONGASSETNAM:GBBD47IF6LWK7P7MDEVSCWR7DPUWV3NY3DTQEVFL4NAT4AQH3ZLLFLA5",
            2000,
        );
        assert!(result.is_ok());

        match result.unwrap() {
            OperationSpec::Payment {
                destination,
                amount,
                asset,
            } => {
                assert_eq!(destination, TEST_ACCOUNT);
                assert_eq!(amount, 2000);
                match asset {
                    AssetSpec::Credit12 { code, issuer } => {
                        assert_eq!(code, "LONGASSETNAM");
                        assert_eq!(
                            issuer,
                            "GBBD47IF6LWK7P7MDEVSCWR7DPUWV3NY3DTQEVFL4NAT4AQH3ZLLFLA5"
                        );
                    }
                    _ => panic!("Expected Credit12 asset"),
                }
            }
            _ => panic!("Expected Payment operation"),
        }
    }

    #[test]
    fn test_create_payment_empty_asset() {
        let result = create_fee_payment_operation(TEST_ACCOUNT, "", 1000);
        assert!(result.is_ok());

        match result.unwrap() {
            OperationSpec::Payment { asset, .. } => {
                assert!(matches!(asset, AssetSpec::Native));
            }
            _ => panic!("Expected Payment operation"),
        }
    }

    #[test]
    fn test_create_payment_invalid_format() {
        let result = create_fee_payment_operation(TEST_ACCOUNT, "INVALID_FORMAT", 1000);
        assert!(result.is_err());

        match result.unwrap_err() {
            StellarTransactionUtilsError::InvalidAssetFormat(_) => {}
            _ => panic!("Expected InvalidAssetFormat error"),
        }
    }

    #[test]
    fn test_create_payment_asset_code_too_long() {
        let result = create_fee_payment_operation(
            TEST_ACCOUNT,
            "VERYLONGASSETCODE:GBBD47IF6LWK7P7MDEVSCWR7DPUWV3NY3DTQEVFL4NAT4AQH3ZLLFLA5",
            1000,
        );
        assert!(result.is_err());

        match result.unwrap_err() {
            StellarTransactionUtilsError::AssetCodeTooLong(max_len, _) => {
                assert_eq!(max_len, 12);
            }
            _ => panic!("Expected AssetCodeTooLong error"),
        }
    }
}

#[cfg(test)]
mod parse_account_id_tests {
    use super::*;
    use crate::domain::transaction::stellar::test_helpers::TEST_PK;

    #[test]
    fn test_parse_account_id_valid() {
        let result = parse_account_id(TEST_PK);
        assert!(result.is_ok());

        let account_id = result.unwrap();
        match account_id.0 {
            soroban_rs::xdr::PublicKey::PublicKeyTypeEd25519(_) => {}
        }
    }

    #[test]
    fn test_parse_account_id_invalid() {
        let result = parse_account_id("INVALID_ADDRESS");
        assert!(result.is_err());

        match result.unwrap_err() {
            StellarTransactionUtilsError::InvalidAccountAddress(addr, _) => {
                assert_eq!(addr, "INVALID_ADDRESS");
            }
            _ => panic!("Expected InvalidAccountAddress error"),
        }
    }

    #[test]
    fn test_parse_account_id_empty() {
        let result = parse_account_id("");
        assert!(result.is_err());
    }

    #[test]
    fn test_parse_account_id_wrong_prefix() {
        // Contract address instead of account
        let result = parse_account_id("CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD2KM");
        assert!(result.is_err());
    }
}

#[cfg(test)]
mod parse_transaction_and_count_operations_tests {
    use super::*;
    use crate::domain::transaction::stellar::test_helpers::{
        create_native_payment_operation, create_xdr_with_operations, TEST_PK, TEST_PK_2,
    };
    use serde_json::json;

    fn create_test_xdr_with_operations(num_ops: usize) -> String {
        let payment_op = create_native_payment_operation(TEST_PK_2, 100);
        let operations = vec![payment_op; num_ops];
        create_xdr_with_operations(TEST_PK, operations, false)
    }

    #[test]
    fn test_parse_xdr_string() {
        let xdr = create_test_xdr_with_operations(2);
        let json_value = json!(xdr);

        let result = parse_transaction_and_count_operations(&json_value);
        assert!(result.is_ok());
        assert_eq!(result.unwrap(), 2);
    }

    #[test]
    fn test_parse_operations_array() {
        let json_value = json!([
            {"type": "payment"},
            {"type": "payment"},
            {"type": "payment"}
        ]);

        let result = parse_transaction_and_count_operations(&json_value);
        assert!(result.is_ok());
        assert_eq!(result.unwrap(), 3);
    }

    #[test]
    fn test_parse_object_with_operations() {
        let json_value = json!({
            "operations": [
                {"type": "payment"},
                {"type": "payment"}
            ]
        });

        let result = parse_transaction_and_count_operations(&json_value);
        assert!(result.is_ok());
        assert_eq!(result.unwrap(), 2);
    }

    #[test]
    fn test_parse_object_with_transaction_xdr() {
        let xdr = create_test_xdr_with_operations(3);
        let json_value = json!({
            "transaction_xdr": xdr
        });

        let result = parse_transaction_and_count_operations(&json_value);
        assert!(result.is_ok());
        assert_eq!(result.unwrap(), 3);
    }

    #[test]
    fn test_parse_invalid_xdr() {
        let json_value = json!("INVALID_XDR");

        let result = parse_transaction_and_count_operations(&json_value);
        assert!(result.is_err());

        match result.unwrap_err() {
            StellarTransactionUtilsError::XdrParseFailed(_) => {}
            _ => panic!("Expected XdrParseFailed error"),
        }
    }

    #[test]
    fn test_parse_invalid_format() {
        let json_value = json!(123);

        let result = parse_transaction_and_count_operations(&json_value);
        assert!(result.is_err());

        match result.unwrap_err() {
            StellarTransactionUtilsError::InvalidTransactionFormat(_) => {}
            _ => panic!("Expected InvalidTransactionFormat error"),
        }
    }

    #[test]
    fn test_parse_empty_operations() {
        let json_value = json!([]);

        let result = parse_transaction_and_count_operations(&json_value);
        assert!(result.is_ok());
        assert_eq!(result.unwrap(), 0);
    }
}

#[cfg(test)]
mod parse_transaction_envelope_tests {
    use super::*;
    use crate::domain::transaction::stellar::test_helpers::{
        create_unsigned_xdr, TEST_PK, TEST_PK_2,
    };
    use serde_json::json;

    fn create_test_xdr() -> String {
        create_unsigned_xdr(TEST_PK, TEST_PK_2)
    }

    #[test]
    fn test_parse_xdr_string() {
        let xdr = create_test_xdr();
        let json_value = json!(xdr);

        let result = parse_transaction_envelope(&json_value);
        assert!(result.is_ok());

        match result.unwrap() {
            TransactionEnvelope::Tx(_) => {}
            _ => panic!("Expected Tx envelope"),
        }
    }

    #[test]
    fn test_parse_object_with_transaction_xdr() {
        let xdr = create_test_xdr();
        let json_value = json!({
            "transaction_xdr": xdr
        });

        let result = parse_transaction_envelope(&json_value);
        assert!(result.is_ok());

        match result.unwrap() {
            TransactionEnvelope::Tx(_) => {}
            _ => panic!("Expected Tx envelope"),
        }
    }

    #[test]
    fn test_parse_invalid_xdr() {
        let json_value = json!("INVALID_XDR");

        let result = parse_transaction_envelope(&json_value);
        assert!(result.is_err());

        match result.unwrap_err() {
            StellarTransactionUtilsError::XdrParseFailed(_) => {}
            _ => panic!("Expected XdrParseFailed error"),
        }
    }

    #[test]
    fn test_parse_invalid_format() {
        let json_value = json!(123);

        let result = parse_transaction_envelope(&json_value);
        assert!(result.is_err());

        match result.unwrap_err() {
            StellarTransactionUtilsError::InvalidTransactionFormat(_) => {}
            _ => panic!("Expected InvalidTransactionFormat error"),
        }
    }

    #[test]
    fn test_parse_object_without_xdr() {
        let json_value = json!({
            "some_field": "value"
        });

        let result = parse_transaction_envelope(&json_value);
        assert!(result.is_err());

        match result.unwrap_err() {
            StellarTransactionUtilsError::InvalidTransactionFormat(_) => {}
            _ => panic!("Expected InvalidTransactionFormat error"),
        }
    }
}

#[cfg(test)]
mod add_operation_to_envelope_tests {
    use super::*;
    use soroban_rs::xdr::{
        Memo, MuxedAccount, Operation, OperationBody, PaymentOp, Preconditions, SequenceNumber,
        Transaction, TransactionExt, TransactionV0, TransactionV0Envelope, TransactionV1Envelope,
        Uint256,
    };

    fn create_payment_op() -> Operation {
        Operation {
            source_account: None,
            body: OperationBody::Payment(PaymentOp {
                destination: MuxedAccount::Ed25519(Uint256([1u8; 32])),
                asset: Asset::Native,
                amount: 100,
            }),
        }
    }

    #[test]
    fn test_add_operation_to_tx_v0() {
        let payment_op = create_payment_op();
        let operations = vec![payment_op.clone()].try_into().unwrap();

        let tx = TransactionV0 {
            source_account_ed25519: Uint256([0u8; 32]),
            fee: 100,
            seq_num: SequenceNumber(1),
            time_bounds: None,
            memo: Memo::None,
            operations,
            ext: soroban_rs::xdr::TransactionV0Ext::V0,
        };

        let mut envelope = TransactionEnvelope::TxV0(TransactionV0Envelope {
            tx,
            signatures: vec![].try_into().unwrap(),
        });

        let new_op = create_payment_op();
        let result = add_operation_to_envelope(&mut envelope, new_op);

        assert!(result.is_ok());

        match envelope {
            TransactionEnvelope::TxV0(e) => {
                assert_eq!(e.tx.operations.len(), 2);
                assert_eq!(e.tx.fee, 200); // 100 stroops per operation
            }
            _ => panic!("Expected TxV0 envelope"),
        }
    }

    #[test]
    fn test_add_operation_to_tx_v1() {
        let payment_op = create_payment_op();
        let operations = vec![payment_op.clone()].try_into().unwrap();

        let tx = Transaction {
            source_account: MuxedAccount::Ed25519(Uint256([0u8; 32])),
            fee: 100,
            seq_num: SequenceNumber(1),
            cond: Preconditions::None,
            memo: Memo::None,
            operations,
            ext: TransactionExt::V0,
        };

        let mut envelope = TransactionEnvelope::Tx(TransactionV1Envelope {
            tx,
            signatures: vec![].try_into().unwrap(),
        });

        let new_op = create_payment_op();
        let result = add_operation_to_envelope(&mut envelope, new_op);

        assert!(result.is_ok());

        match envelope {
            TransactionEnvelope::Tx(e) => {
                assert_eq!(e.tx.operations.len(), 2);
                assert_eq!(e.tx.fee, 200); // 100 stroops per operation
            }
            _ => panic!("Expected Tx envelope"),
        }
    }

    #[test]
    fn test_add_operation_to_fee_bump_fails() {
        // Create a simple inner transaction
        let payment_op = create_payment_op();
        let operations = vec![payment_op].try_into().unwrap();

        let tx = Transaction {
            source_account: MuxedAccount::Ed25519(Uint256([0u8; 32])),
            fee: 100,
            seq_num: SequenceNumber(1),
            cond: Preconditions::None,
            memo: Memo::None,
            operations,
            ext: TransactionExt::V0,
        };

        let inner_envelope = TransactionV1Envelope {
            tx,
            signatures: vec![].try_into().unwrap(),
        };

        let inner_tx = soroban_rs::xdr::FeeBumpTransactionInnerTx::Tx(inner_envelope);

        let fee_bump_tx = soroban_rs::xdr::FeeBumpTransaction {
            fee_source: MuxedAccount::Ed25519(Uint256([2u8; 32])),
            fee: 200,
            inner_tx,
            ext: soroban_rs::xdr::FeeBumpTransactionExt::V0,
        };

        let mut envelope =
            TransactionEnvelope::TxFeeBump(soroban_rs::xdr::FeeBumpTransactionEnvelope {
                tx: fee_bump_tx,
                signatures: vec![].try_into().unwrap(),
            });

        let new_op = create_payment_op();
        let result = add_operation_to_envelope(&mut envelope, new_op);

        assert!(result.is_err());

        match result.unwrap_err() {
            StellarTransactionUtilsError::CannotModifyFeeBump => {}
            _ => panic!("Expected CannotModifyFeeBump error"),
        }
    }
}

#[cfg(test)]
mod extract_time_bounds_tests {
    use super::*;
    use soroban_rs::xdr::{
        Memo, MuxedAccount, Operation, OperationBody, PaymentOp, Preconditions, SequenceNumber,
        TimeBounds, TimePoint, Transaction, TransactionExt, TransactionV0, TransactionV0Envelope,
        TransactionV1Envelope, Uint256,
    };

    fn create_payment_op() -> Operation {
        Operation {
            source_account: None,
            body: OperationBody::Payment(PaymentOp {
                destination: MuxedAccount::Ed25519(Uint256([1u8; 32])),
                asset: Asset::Native,
                amount: 100,
            }),
        }
    }

    #[test]
    fn test_extract_time_bounds_from_tx_v0_with_bounds() {
        let payment_op = create_payment_op();
        let operations = vec![payment_op].try_into().unwrap();

        let time_bounds = TimeBounds {
            min_time: TimePoint(0),
            max_time: TimePoint(1000),
        };

        let tx = TransactionV0 {
            source_account_ed25519: Uint256([0u8; 32]),
            fee: 100,
            seq_num: SequenceNumber(1),
            time_bounds: Some(time_bounds.clone()),
            memo: Memo::None,
            operations,
            ext: soroban_rs::xdr::TransactionV0Ext::V0,
        };

        let envelope = TransactionEnvelope::TxV0(TransactionV0Envelope {
            tx,
            signatures: vec![].try_into().unwrap(),
        });

        let result = extract_time_bounds(&envelope);
        assert!(result.is_some());

        let bounds = result.unwrap();
        assert_eq!(bounds.min_time.0, 0);
        assert_eq!(bounds.max_time.0, 1000);
    }

    #[test]
    fn test_extract_time_bounds_from_tx_v0_without_bounds() {
        let payment_op = create_payment_op();
        let operations = vec![payment_op].try_into().unwrap();

        let tx = TransactionV0 {
            source_account_ed25519: Uint256([0u8; 32]),
            fee: 100,
            seq_num: SequenceNumber(1),
            time_bounds: None,
            memo: Memo::None,
            operations,
            ext: soroban_rs::xdr::TransactionV0Ext::V0,
        };

        let envelope = TransactionEnvelope::TxV0(TransactionV0Envelope {
            tx,
            signatures: vec![].try_into().unwrap(),
        });

        let result = extract_time_bounds(&envelope);
        assert!(result.is_none());
    }

    #[test]
    fn test_extract_time_bounds_from_tx_v1_with_time_precondition() {
        let payment_op = create_payment_op();
        let operations = vec![payment_op].try_into().unwrap();

        let time_bounds = TimeBounds {
            min_time: TimePoint(0),
            max_time: TimePoint(2000),
        };

        let tx = Transaction {
            source_account: MuxedAccount::Ed25519(Uint256([0u8; 32])),
            fee: 100,
            seq_num: SequenceNumber(1),
            cond: Preconditions::Time(time_bounds.clone()),
            memo: Memo::None,
            operations,
            ext: TransactionExt::V0,
        };

        let envelope = TransactionEnvelope::Tx(TransactionV1Envelope {
            tx,
            signatures: vec![].try_into().unwrap(),
        });

        let result = extract_time_bounds(&envelope);
        assert!(result.is_some());

        let bounds = result.unwrap();
        assert_eq!(bounds.min_time.0, 0);
        assert_eq!(bounds.max_time.0, 2000);
    }

    #[test]
    fn test_extract_time_bounds_from_tx_v1_without_time_precondition() {
        let payment_op = create_payment_op();
        let operations = vec![payment_op].try_into().unwrap();

        let tx = Transaction {
            source_account: MuxedAccount::Ed25519(Uint256([0u8; 32])),
            fee: 100,
            seq_num: SequenceNumber(1),
            cond: Preconditions::None,
            memo: Memo::None,
            operations,
            ext: TransactionExt::V0,
        };

        let envelope = TransactionEnvelope::Tx(TransactionV1Envelope {
            tx,
            signatures: vec![].try_into().unwrap(),
        });

        let result = extract_time_bounds(&envelope);
        assert!(result.is_none());
    }

    #[test]
    fn test_extract_time_bounds_from_fee_bump() {
        // Create inner transaction with time bounds
        let payment_op = create_payment_op();
        let operations = vec![payment_op].try_into().unwrap();

        let time_bounds = TimeBounds {
            min_time: TimePoint(0),
            max_time: TimePoint(3000),
        };

        let tx = Transaction {
            source_account: MuxedAccount::Ed25519(Uint256([0u8; 32])),
            fee: 100,
            seq_num: SequenceNumber(1),
            cond: Preconditions::Time(time_bounds.clone()),
            memo: Memo::None,
            operations,
            ext: TransactionExt::V0,
        };

        let inner_envelope = TransactionV1Envelope {
            tx,
            signatures: vec![].try_into().unwrap(),
        };

        let inner_tx = soroban_rs::xdr::FeeBumpTransactionInnerTx::Tx(inner_envelope);

        let fee_bump_tx = soroban_rs::xdr::FeeBumpTransaction {
            fee_source: MuxedAccount::Ed25519(Uint256([2u8; 32])),
            fee: 200,
            inner_tx,
            ext: soroban_rs::xdr::FeeBumpTransactionExt::V0,
        };

        let envelope =
            TransactionEnvelope::TxFeeBump(soroban_rs::xdr::FeeBumpTransactionEnvelope {
                tx: fee_bump_tx,
                signatures: vec![].try_into().unwrap(),
            });

        let result = extract_time_bounds(&envelope);
        assert!(result.is_some());

        let bounds = result.unwrap();
        assert_eq!(bounds.min_time.0, 0);
        assert_eq!(bounds.max_time.0, 3000);
    }
}

#[cfg(test)]
mod set_time_bounds_tests {
    use super::*;
    use chrono::Utc;
    use soroban_rs::xdr::{
        Memo, MuxedAccount, Operation, OperationBody, PaymentOp, Preconditions, SequenceNumber,
        TimeBounds, TimePoint, Transaction, TransactionExt, TransactionV0, TransactionV0Envelope,
        TransactionV1Envelope, Uint256,
    };

    fn create_payment_op() -> Operation {
        Operation {
            source_account: None,
            body: OperationBody::Payment(PaymentOp {
                destination: MuxedAccount::Ed25519(Uint256([1u8; 32])),
                asset: Asset::Native,
                amount: 100,
            }),
        }
    }

    #[test]
    fn test_set_time_bounds_on_tx_v0() {
        let payment_op = create_payment_op();
        let operations = vec![payment_op].try_into().unwrap();

        let tx = TransactionV0 {
            source_account_ed25519: Uint256([0u8; 32]),
            fee: 100,
            seq_num: SequenceNumber(1),
            time_bounds: None,
            memo: Memo::None,
            operations,
            ext: soroban_rs::xdr::TransactionV0Ext::V0,
        };

        let mut envelope = TransactionEnvelope::TxV0(TransactionV0Envelope {
            tx,
            signatures: vec![].try_into().unwrap(),
        });

        let valid_until = Utc::now() + chrono::Duration::seconds(300);
        let result = set_time_bounds(&mut envelope, valid_until);

        assert!(result.is_ok());

        match envelope {
            TransactionEnvelope::TxV0(e) => {
                assert!(e.tx.time_bounds.is_some());
                let bounds = e.tx.time_bounds.unwrap();
                assert_eq!(bounds.min_time.0, 0);
                assert_eq!(bounds.max_time.0, valid_until.timestamp() as u64);
            }
            _ => panic!("Expected TxV0 envelope"),
        }
    }

    #[test]
    fn test_set_time_bounds_on_tx_v1() {
        let payment_op = create_payment_op();
        let operations = vec![payment_op].try_into().unwrap();

        let tx = Transaction {
            source_account: MuxedAccount::Ed25519(Uint256([0u8; 32])),
            fee: 100,
            seq_num: SequenceNumber(1),
            cond: Preconditions::None,
            memo: Memo::None,
            operations,
            ext: TransactionExt::V0,
        };

        let mut envelope = TransactionEnvelope::Tx(TransactionV1Envelope {
            tx,
            signatures: vec![].try_into().unwrap(),
        });

        let valid_until = Utc::now() + chrono::Duration::seconds(300);
        let result = set_time_bounds(&mut envelope, valid_until);

        assert!(result.is_ok());

        match envelope {
            TransactionEnvelope::Tx(e) => match e.tx.cond {
                Preconditions::Time(bounds) => {
                    assert_eq!(bounds.min_time.0, 0);
                    assert_eq!(bounds.max_time.0, valid_until.timestamp() as u64);
                }
                _ => panic!("Expected Time precondition"),
            },
            _ => panic!("Expected Tx envelope"),
        }
    }

    #[test]
    fn test_set_time_bounds_on_fee_bump_fails() {
        // Create a simple inner transaction
        let payment_op = create_payment_op();
        let operations = vec![payment_op].try_into().unwrap();

        let tx = Transaction {
            source_account: MuxedAccount::Ed25519(Uint256([0u8; 32])),
            fee: 100,
            seq_num: SequenceNumber(1),
            cond: Preconditions::None,
            memo: Memo::None,
            operations,
            ext: TransactionExt::V0,
        };

        let inner_envelope = TransactionV1Envelope {
            tx,
            signatures: vec![].try_into().unwrap(),
        };

        let inner_tx = soroban_rs::xdr::FeeBumpTransactionInnerTx::Tx(inner_envelope);

        let fee_bump_tx = soroban_rs::xdr::FeeBumpTransaction {
            fee_source: MuxedAccount::Ed25519(Uint256([2u8; 32])),
            fee: 200,
            inner_tx,
            ext: soroban_rs::xdr::FeeBumpTransactionExt::V0,
        };

        let mut envelope =
            TransactionEnvelope::TxFeeBump(soroban_rs::xdr::FeeBumpTransactionEnvelope {
                tx: fee_bump_tx,
                signatures: vec![].try_into().unwrap(),
            });

        let valid_until = Utc::now() + chrono::Duration::seconds(300);
        let result = set_time_bounds(&mut envelope, valid_until);

        assert!(result.is_err());

        match result.unwrap_err() {
            StellarTransactionUtilsError::CannotSetTimeBoundsOnFeeBump => {}
            _ => panic!("Expected CannotSetTimeBoundsOnFeeBump error"),
        }
    }

    #[test]
    fn test_set_time_bounds_replaces_existing() {
        let payment_op = create_payment_op();
        let operations = vec![payment_op].try_into().unwrap();

        let old_time_bounds = TimeBounds {
            min_time: TimePoint(100),
            max_time: TimePoint(1000),
        };

        let tx = TransactionV0 {
            source_account_ed25519: Uint256([0u8; 32]),
            fee: 100,
            seq_num: SequenceNumber(1),
            time_bounds: Some(old_time_bounds),
            memo: Memo::None,
            operations,
            ext: soroban_rs::xdr::TransactionV0Ext::V0,
        };

        let mut envelope = TransactionEnvelope::TxV0(TransactionV0Envelope {
            tx,
            signatures: vec![].try_into().unwrap(),
        });

        let valid_until = Utc::now() + chrono::Duration::seconds(300);
        let result = set_time_bounds(&mut envelope, valid_until);

        assert!(result.is_ok());

        match envelope {
            TransactionEnvelope::TxV0(e) => {
                assert!(e.tx.time_bounds.is_some());
                let bounds = e.tx.time_bounds.unwrap();
                // Should replace with new bounds (min_time = 0, not 100)
                assert_eq!(bounds.min_time.0, 0);
                assert_eq!(bounds.max_time.0, valid_until.timestamp() as u64);
            }
            _ => panic!("Expected TxV0 envelope"),
        }
    }
}

// ============================================================================
// From<StellarTransactionUtilsError> for RelayerError Tests
// ============================================================================

#[cfg(test)]
mod stellar_transaction_utils_error_conversion_tests {
    use super::*;

    #[test]
    fn test_v0_transactions_not_supported_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::V0TransactionsNotSupported;
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert_eq!(msg, "V0 transactions are not supported");
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_cannot_update_sequence_on_fee_bump_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::CannotUpdateSequenceOnFeeBump;
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert_eq!(msg, "Cannot update sequence number on fee bump transaction");
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_cannot_set_time_bounds_on_fee_bump_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::CannotSetTimeBoundsOnFeeBump;
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert_eq!(msg, "Cannot set time bounds on fee-bump transactions");
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_invalid_transaction_format_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::InvalidTransactionFormat("bad format".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert_eq!(msg, "bad format");
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_cannot_modify_fee_bump_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::CannotModifyFeeBump;
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert_eq!(msg, "Cannot add operations to fee-bump transactions");
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_too_many_operations_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::TooManyOperations(100);
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert!(msg.contains("Too many operations"));
                assert!(msg.contains("100"));
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_sequence_overflow_converts_to_internal_error() {
        let err = StellarTransactionUtilsError::SequenceOverflow("overflow msg".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::Internal(msg) => {
                assert_eq!(msg, "overflow msg");
            }
            _ => panic!("Expected Internal error"),
        }
    }

    #[test]
    fn test_simulation_no_results_converts_to_internal_error() {
        let err = StellarTransactionUtilsError::SimulationNoResults;
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::Internal(msg) => {
                assert!(msg.contains("no results"));
            }
            _ => panic!("Expected Internal error"),
        }
    }

    #[test]
    fn test_asset_code_too_long_converts_to_validation_error() {
        let err =
            StellarTransactionUtilsError::AssetCodeTooLong(12, "VERYLONGASSETCODE".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert!(msg.contains("Asset code too long"));
                assert!(msg.contains("12"));
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_invalid_asset_format_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::InvalidAssetFormat("bad asset".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert_eq!(msg, "bad asset");
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_invalid_account_address_converts_to_internal_error() {
        let err = StellarTransactionUtilsError::InvalidAccountAddress(
            "GABC".to_string(),
            "parse error".to_string(),
        );
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::Internal(msg) => {
                assert_eq!(msg, "parse error");
            }
            _ => panic!("Expected Internal error"),
        }
    }

    #[test]
    fn test_invalid_contract_address_converts_to_internal_error() {
        let err = StellarTransactionUtilsError::InvalidContractAddress(
            "CABC".to_string(),
            "contract parse error".to_string(),
        );
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::Internal(msg) => {
                assert_eq!(msg, "contract parse error");
            }
            _ => panic!("Expected Internal error"),
        }
    }

    #[test]
    fn test_symbol_creation_failed_converts_to_internal_error() {
        let err = StellarTransactionUtilsError::SymbolCreationFailed(
            "Balance".to_string(),
            "too long".to_string(),
        );
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::Internal(msg) => {
                assert_eq!(msg, "too long");
            }
            _ => panic!("Expected Internal error"),
        }
    }

    #[test]
    fn test_key_vector_creation_failed_converts_to_internal_error() {
        let err = StellarTransactionUtilsError::KeyVectorCreationFailed(
            "Balance".to_string(),
            "vec error".to_string(),
        );
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::Internal(msg) => {
                assert_eq!(msg, "vec error");
            }
            _ => panic!("Expected Internal error"),
        }
    }

    #[test]
    fn test_contract_data_query_persistent_failed_converts_to_internal_error() {
        let err = StellarTransactionUtilsError::ContractDataQueryPersistentFailed(
            "balance".to_string(),
            "rpc error".to_string(),
        );
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::Internal(msg) => {
                assert_eq!(msg, "rpc error");
            }
            _ => panic!("Expected Internal error"),
        }
    }

    #[test]
    fn test_contract_data_query_temporary_failed_converts_to_internal_error() {
        let err = StellarTransactionUtilsError::ContractDataQueryTemporaryFailed(
            "balance".to_string(),
            "temp error".to_string(),
        );
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::Internal(msg) => {
                assert_eq!(msg, "temp error");
            }
            _ => panic!("Expected Internal error"),
        }
    }

    #[test]
    fn test_ledger_entry_parse_failed_converts_to_internal_error() {
        let err = StellarTransactionUtilsError::LedgerEntryParseFailed(
            "entry".to_string(),
            "xdr error".to_string(),
        );
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::Internal(msg) => {
                assert_eq!(msg, "xdr error");
            }
            _ => panic!("Expected Internal error"),
        }
    }

    #[test]
    fn test_no_entries_found_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::NoEntriesFound("balance".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert!(msg.contains("No entries found"));
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_empty_entries_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::EmptyEntries("balance".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert!(msg.contains("Empty entries"));
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_unexpected_ledger_entry_type_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::UnexpectedLedgerEntryType("balance".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert!(msg.contains("Unexpected ledger entry type"));
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_invalid_issuer_length_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::InvalidIssuerLength(56, "SHORT".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert!(msg.contains("56"));
                assert!(msg.contains("SHORT"));
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_invalid_issuer_prefix_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::InvalidIssuerPrefix('G', "CABC123".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert!(msg.contains("'G'"));
                assert!(msg.contains("CABC123"));
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_account_fetch_failed_converts_to_provider_error() {
        let err = StellarTransactionUtilsError::AccountFetchFailed("fetch error".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ProviderError(msg) => {
                assert_eq!(msg, "fetch error");
            }
            _ => panic!("Expected ProviderError"),
        }
    }

    #[test]
    fn test_trustline_query_failed_converts_to_provider_error() {
        let err = StellarTransactionUtilsError::TrustlineQueryFailed(
            "USDC".to_string(),
            "rpc fail".to_string(),
        );
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ProviderError(msg) => {
                assert_eq!(msg, "rpc fail");
            }
            _ => panic!("Expected ProviderError"),
        }
    }

    #[test]
    fn test_contract_invocation_failed_converts_to_provider_error() {
        let err = StellarTransactionUtilsError::ContractInvocationFailed(
            "transfer".to_string(),
            "invoke error".to_string(),
        );
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ProviderError(msg) => {
                assert_eq!(msg, "invoke error");
            }
            _ => panic!("Expected ProviderError"),
        }
    }

    #[test]
    fn test_xdr_parse_failed_converts_to_internal_error() {
        let err = StellarTransactionUtilsError::XdrParseFailed("xdr parse fail".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::Internal(msg) => {
                assert_eq!(msg, "xdr parse fail");
            }
            _ => panic!("Expected Internal error"),
        }
    }

    #[test]
    fn test_operation_extraction_failed_converts_to_internal_error() {
        let err =
            StellarTransactionUtilsError::OperationExtractionFailed("extract fail".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::Internal(msg) => {
                assert_eq!(msg, "extract fail");
            }
            _ => panic!("Expected Internal error"),
        }
    }

    #[test]
    fn test_simulation_failed_converts_to_internal_error() {
        let err = StellarTransactionUtilsError::SimulationFailed("sim error".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::Internal(msg) => {
                assert_eq!(msg, "sim error");
            }
            _ => panic!("Expected Internal error"),
        }
    }

    #[test]
    fn test_simulation_check_failed_converts_to_internal_error() {
        let err = StellarTransactionUtilsError::SimulationCheckFailed("check fail".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::Internal(msg) => {
                assert_eq!(msg, "check fail");
            }
            _ => panic!("Expected Internal error"),
        }
    }

    #[test]
    fn test_dex_quote_failed_converts_to_internal_error() {
        let err = StellarTransactionUtilsError::DexQuoteFailed("dex error".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::Internal(msg) => {
                assert_eq!(msg, "dex error");
            }
            _ => panic!("Expected Internal error"),
        }
    }

    #[test]
    fn test_empty_asset_code_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::EmptyAssetCode("CODE:ISSUER".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert!(msg.contains("Asset code cannot be empty"));
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_empty_issuer_address_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::EmptyIssuerAddress("USDC:".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert!(msg.contains("Issuer address cannot be empty"));
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_no_trustline_found_converts_to_validation_error() {
        let err =
            StellarTransactionUtilsError::NoTrustlineFound("USDC".to_string(), "GABC".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert!(msg.contains("No trustline found"));
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_unsupported_trustline_version_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::UnsupportedTrustlineVersion;
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert!(msg.contains("Unsupported trustline"));
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_unexpected_trustline_entry_type_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::UnexpectedTrustlineEntryType;
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert!(msg.contains("Unexpected ledger entry type"));
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_balance_too_large_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::BalanceTooLarge(1, 999);
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert!(msg.contains("Balance too large"));
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_negative_balance_i128_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::NegativeBalanceI128(42);
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert!(msg.contains("Negative balance"));
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_negative_balance_i64_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::NegativeBalanceI64(-5);
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert!(msg.contains("Negative balance"));
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_unexpected_balance_type_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::UnexpectedBalanceType("Bool(true)".to_string());
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert!(msg.contains("Unexpected balance value type"));
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_unexpected_contract_data_entry_type_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::UnexpectedContractDataEntryType;
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert!(msg.contains("Unexpected ledger entry type"));
            }
            _ => panic!("Expected ValidationError"),
        }
    }

    #[test]
    fn test_native_asset_in_trustline_query_converts_to_validation_error() {
        let err = StellarTransactionUtilsError::NativeAssetInTrustlineQuery;
        let relayer_err: RelayerError = err.into();
        match relayer_err {
            RelayerError::ValidationError(msg) => {
                assert!(msg.contains("Native asset"));
            }
            _ => panic!("Expected ValidationError"),
        }
    }
}